Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 347914 - Update spidermonkey to 1.9.2.13
Summary: Update spidermonkey to 1.9.2.13
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High critical (vote)
Assignee: Dirkjan Ochtman (RETIRED)
URL: http://hg.mozilla.org/tracemonkey/rev...
Whiteboard:
Keywords:
: 266225 (view as bug list)
Depends on:
Blocks: 325849
  Show dependency tree
 
Reported: 2010-12-06 15:44 UTC by Jory A. Pratt
Modified: 2010-12-29 14:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Use current firefox releases for spidermonkey release media/changes (spidermonkey-update.diff,4.27 KB, patch)
2010-12-06 15:45 UTC, Jory A. Pratt
Details | Diff
Proposed patch to allow compilation with USE=threadsafe (spidermonkey_link-order.patch,392 bytes, patch)
2010-12-11 00:51 UTC, Jouni Kosonen
Details | Diff
build.log of threadsafe compile on amd64 (build.log,32.49 KB, text/plain)
2010-12-11 01:46 UTC, Jory A. Pratt
Details
emerge --info (emerge--info.txt,5.07 KB, text/plain)
2010-12-13 11:03 UTC, Jouni Kosonen
Details
build.log for failing threadsafe compile on amd64 (build.log,91.96 KB, text/plain)
2010-12-13 11:07 UTC, Jouni Kosonen
Details
spidermonkey-1.9.2-nspr-includes.patch (spidermonkey-1.9.2-nspr-includes.patch,600 bytes, patch)
2010-12-27 20:12 UTC, Jory A. Pratt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jory A. Pratt gentoo-dev 2010-12-06 15:44:31 UTC
You can use the source for firefox for your spidermonkey builds, this will put your current. I will attach in just a minute an updated ebuild fully working, threading support is needed no matter what as configure will fail if not avaliale.
Comment 1 Jory A. Pratt gentoo-dev 2010-12-06 15:45:27 UTC
Created attachment 256504 [details, diff]
Use current firefox releases for spidermonkey release media/changes

This is fully tested and working hope this will get you all back on track.
Comment 2 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-12-06 15:49:38 UTC
Alexis: I talked about this with Jory on IRC. I think it would be nice if we had a newer version since it doesn't look like Mozilla will release newer stand-alone JS tarballs anytime soon. If you're not interested anymore, I'd be happy to take over (or co-maintain).
Comment 3 Jory A. Pratt gentoo-dev 2010-12-06 17:27:02 UTC
(In reply to comment #2)
> Alexis: I talked about this with Jory on IRC. I think it would be nice if we
> had a newer version since it doesn't look like Mozilla will release newer
> stand-alone JS tarballs anytime soon. If you're not interested anymore, I'd be
> happy to take over (or co-maintain).
> 

There will be no more standalone tarballs, all distros have been moved to using the firefox release media and compiling it just as I have done in the ebuild.
Comment 4 Jory A. Pratt gentoo-dev 2010-12-06 17:30:04 UTC
(In reply to comment #0)
> You can use the source for firefox for your spidermonkey builds, this will put
> your current. I will attach in just a minute an updated ebuild fully working,
> threading support is needed no matter what as configure will fail if not
> avaliale.
> 

The comment about threading being required is invalid, this has been worked around in the attached patch.
Comment 5 Alexis Ballier gentoo-dev 2010-12-09 19:00:37 UTC
(In reply to comment #2)
> Alexis: I talked about this with Jory on IRC. I think it would be nice if we
> had a newer version since it doesn't look like Mozilla will release newer
> stand-alone JS tarballs anytime soon. If you're not interested anymore, I'd be
> happy to take over (or co-maintain).
> 

Please do so, I'm not using it anymore, and, to be honest, I'm a bit ashamed since I've not been maintaining it for ages.
At a time nobody seemed interested in adopting it so I kept myself as official maintainer, I'd be very glad if you could pick it up and remove me from maintainers.
Comment 6 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-12-09 19:20:17 UTC
Good then, this will work out great for all of us. Jory, want to co-maintain?
Comment 7 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-12-09 19:32:22 UTC
Hmm, the new ebuild doesn't seem to compile for me. I get a bunch of errors about undefined references to PR_Lock, PR_Unlock, and a number of other PR_* functions. I thought those should be part of NSPR, but I have that installed (4.8.6).
Comment 8 Jory A. Pratt gentoo-dev 2010-12-09 23:52:48 UTC
(In reply to comment #7)
> Hmm, the new ebuild doesn't seem to compile for me. I get a bunch of errors
> about undefined references to PR_Lock, PR_Unlock, and a number of other PR_*
> functions. I thought those should be part of NSPR, but I have that installed
> (4.8.6).
> 

interesting compiles fine here, as co-matinainer no, please place mozilla as herd tho we will assist when needed.
Comment 9 Jouni Kosonen 2010-12-11 00:51:18 UTC
Created attachment 256874 [details, diff]
Proposed patch to allow compilation with USE=threadsafe

Doesn't seem to want to compile with USE=threadsafe here either, fails when linking jsapi-tests.

The problematic part looks like this in the build log:

x86_64-pc-linux-gnu-g++ -o jsapi-tests  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Wno-long-long -pedantic -march=amdfam10 -O2 -pipe -fno-strict-aliasing -pthread -pipe  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions   tests.o selfTest.o testPropCache.o testXDR.o testIntString.o testIsAboutToBeFinalized.o testSameValue.o testDebugger.o testDefineGetterSetterNonEnumerable.o testExtendedEq.o    -lpthread -Wl,-O1 -Wl,--as-needed  -Wl,-rpath-link,/bin -Wl,-rpath-link,/lib  -L../dist/bin -L../dist/lib -Wl,-R/usr/lib64 -L/usr/lib64 -lplds4 -lplc4 -lnspr4 -lpthread -ldl ../libjs_static.a -ldl -lm      
../libjs_static.a(jsapi.o): In function `JS_Finish':
jsapi.cpp:(.text+0xedb): undefined reference to `PR_DestroyLock'
jsapi.cpp:(.text+0xeec): undefined reference to `PR_DestroyCondVar'
jsapi.cpp:(.text+0xefd): undefined reference to `PR_DestroyCondVar'
jsapi.cpp:(.text+0xf0e): undefined reference to `PR_DestroyLock'
jsapi.cpp:(.text+0xf1f): undefined reference to `PR_DestroyCondVar'
jsapi.cpp:(.text+0xf30): undefined reference to `PR_DestroyCondVar'
jsapi.cpp:(.text+0xf41): undefined reference to `PR_DestroyLock'
../libjs_static.a(jsapi.o): In function `JS_Init':
jsapi.cpp:(.text+0x104d): undefined reference to `PR_NewLock'
jsapi.cpp:(.text+0x1065): undefined reference to `PR_NewCondVar'
jsapi.cpp:(.text+0x1081): undefined reference to `PR_NewCondVar'
jsapi.cpp:(.text+0x10ad): undefined reference to `PR_NewLock'
...etc..

so the nspr libraries containing the PR_* symbols are there like they should be, but the libjs_static.a wanting to use the symbols is too late in the command line.

I'm not that familiar with the mozilla sources, but changing the library order in js/src/jsapi-tests/Makefile.in is enough to allow the compilation to finish at least here.
Comment 10 Jory A. Pratt gentoo-dev 2010-12-11 01:40:58 UTC
(In reply to comment #9)
> Created an attachment (id=256874) [details]
> Proposed patch to allow compilation with USE=threadsafe
> 
> Doesn't seem to want to compile with USE=threadsafe here either, fails when
> linking jsapi-tests.
> 
> The problematic part looks like this in the build log:
> 
> x86_64-pc-linux-gnu-g++ -o jsapi-tests  -fno-rtti -fno-exceptions -Wall
> -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
> -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros
> -Wno-long-long -pedantic -march=amdfam10 -O2 -pipe -fno-strict-aliasing
> -pthread -pipe  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions 
>  tests.o selfTest.o testPropCache.o testXDR.o testIntString.o
> testIsAboutToBeFinalized.o testSameValue.o testDebugger.o
> testDefineGetterSetterNonEnumerable.o testExtendedEq.o    -lpthread -Wl,-O1
> -Wl,--as-needed  -Wl,-rpath-link,/bin -Wl,-rpath-link,/lib  -L../dist/bin
> -L../dist/lib -Wl,-R/usr/lib64 -L/usr/lib64 -lplds4 -lplc4 -lnspr4 -lpthread
> -ldl ../libjs_static.a -ldl -lm      
> ../libjs_static.a(jsapi.o): In function `JS_Finish':
> jsapi.cpp:(.text+0xedb): undefined reference to `PR_DestroyLock'
> jsapi.cpp:(.text+0xeec): undefined reference to `PR_DestroyCondVar'
> jsapi.cpp:(.text+0xefd): undefined reference to `PR_DestroyCondVar'
> jsapi.cpp:(.text+0xf0e): undefined reference to `PR_DestroyLock'
> jsapi.cpp:(.text+0xf1f): undefined reference to `PR_DestroyCondVar'
> jsapi.cpp:(.text+0xf30): undefined reference to `PR_DestroyCondVar'
> jsapi.cpp:(.text+0xf41): undefined reference to `PR_DestroyLock'
> ../libjs_static.a(jsapi.o): In function `JS_Init':
> jsapi.cpp:(.text+0x104d): undefined reference to `PR_NewLock'
> jsapi.cpp:(.text+0x1065): undefined reference to `PR_NewCondVar'
> jsapi.cpp:(.text+0x1081): undefined reference to `PR_NewCondVar'
> jsapi.cpp:(.text+0x10ad): undefined reference to `PR_NewLock'
> ...etc..
> 
> so the nspr libraries containing the PR_* symbols are there like they should
> be, but the libjs_static.a wanting to use the symbols is too late in the
> command line.
> 
> I'm not that familiar with the mozilla sources, but changing the library order
> in js/src/jsapi-tests/Makefile.in is enough to allow the compilation to finish
> at least here.
> 

Include your emerge --info if you want to get this resolved.
Comment 11 Jory A. Pratt gentoo-dev 2010-12-11 01:46:07 UTC
Created attachment 256875 [details]
build.log of threadsafe compile on amd64

Proposed patch is incorrect, I need the emerge --info if I am to fix the issue.
Comment 12 Jory A. Pratt gentoo-dev 2010-12-11 01:52:01 UTC
I should have made a note ... http://git.overlays.gentoo.org/gitweb/?p=proj/mozilla.git;a=commit;h=27c29e08bef9e19ad3695a1bc290ca50ec5e0566

track it via mozilla overlay. Dirkjan I will co-maintain if you still would like.
Comment 13 Jouni Kosonen 2010-12-13 11:03:22 UTC
Created attachment 257014 [details]
emerge --info
Comment 14 Jouni Kosonen 2010-12-13 11:07:28 UTC
Created attachment 257016 [details]
build.log for failing threadsafe compile on amd64

renamed to dev-lang/spidermonkey-1.9.2.13 in local overlay
Comment 15 vsync 2010-12-26 07:27:32 UTC
I'm seeing the issue as well where I'm unable to compile dev-lang/spidermonkey-1.9.2.13.
Comment 16 Jory A. Pratt gentoo-dev 2010-12-27 20:01:56 UTC
(In reply to comment #14)
> Created an attachment (id=257016) [details]
> build.log for failing threadsafe compile on amd64
> 
> renamed to dev-lang/spidermonkey-1.9.2.13 in local overlay
> 

(In reply to comment #15)
> I'm seeing the issue as well where I'm unable to compile
> dev-lang/spidermonkey-1.9.2.13.
> 

What version of nspr do you all have installed? 
Comment 17 Jory A. Pratt gentoo-dev 2010-12-27 20:12:50 UTC
Created attachment 258207 [details, diff]
spidermonkey-1.9.2-nspr-includes.patch

If anyone would test and report would speed things along, I do not see why it should change anything but who knows.
Comment 18 Jory A. Pratt gentoo-dev 2010-12-28 23:28:01 UTC
(In reply to comment #15)
> I'm seeing the issue as well where I'm unable to compile
> dev-lang/spidermonkey-1.9.2.13.
> 

(In reply to comment #7)
> Hmm, the new ebuild doesn't seem to compile for me. I get a bunch of errors
> about undefined references to PR_Lock, PR_Unlock, and a number of other PR_*
> functions. I thought those should be part of NSPR, but I have that installed
> (4.8.6).
> 

Okay finally I know what the problem is and I am addressing it, it is nothing more then as-needed causing the breakage.
Comment 19 Jory A. Pratt gentoo-dev 2010-12-29 00:05:19 UTC
Overlay is fixed, soon as I get a confirmation I will move it to the tree. Thanks for all the reports so far.
Comment 20 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-12-29 08:33:47 UTC
Seems to work for me! Can we add a src_test() to run some of the tests?
Comment 21 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-12-29 08:34:28 UTC
BTW, there is this QA notice, not sure if you see it too?

 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * jsvector.h:148: warning: dereferencing pointer 'dst' does break strict-aliasing rules

Maybe we can send up a patch for that.
Comment 22 Jory A. Pratt gentoo-dev 2010-12-29 13:39:44 UTC
(In reply to comment #20)
> Seems to work for me! Can we add a src_test() to run some of the tests?
> 

Of course you can.

(In reply to comment #21)
> BTW, there is this QA notice, not sure if you see it too?
> 
>  * QA Notice: Package has poor programming practices which may compile
>  *            fine but exhibit random runtime failures.
>  * jsvector.h:148: warning: dereferencing pointer 'dst' does break
> strict-aliasing rules
> 
> Maybe we can send up a patch for that.
> 

I am sure I can push something up for it, soon as we get this in tree tho I will work on spidermonkey-2.0 which might have addressed it already.
Comment 23 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-12-29 14:15:30 UTC
*** Bug 266225 has been marked as a duplicate of this bug. ***
Comment 24 Dirkjan Ochtman (RETIRED) gentoo-dev 2010-12-29 14:24:16 UTC
We now have 1.9.2.13 in the tree.