Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 346933 - sci-physics/root is not prefix clean
Summary: sci-physics/root is not prefix clean
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
: 346931 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-27 07:18 UTC by Benda Xu
Modified: 2012-01-21 19:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
prefixify patch (root-5.26.00e-r1.diff,1.26 KB, patch)
2010-11-30 12:49 UTC, Benda Xu
Details | Diff
final (root-5.26.00e-r1.patch,1.89 KB, patch)
2010-12-01 07:31 UTC, Benda Xu
Details | Diff
enable rpath in prefix env, add ~amd64-linux keyword (root-5.28.00b-prefix_rpath.patch,969 bytes, patch)
2011-04-28 09:20 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2010-11-27 07:18:27 UTC
the configure script of sci-physics is an ad-hoc, home made one, which is hard
wired to check /usr/lib, etc. This would make the result software depending on
libraries from outside prefix.

Reproducible: Always

Steps to Reproduce:
emerge root

Actual Results:  
configure outputs dependencies outside prefix.


What is the recommended way to fix this? patch the configure? Contact upstream?


Reproducible: Always

Steps to Reproduce:
Comment 1 Jonathan Callen (RETIRED) gentoo-dev 2010-11-27 16:22:11 UTC
*** Bug 346931 has been marked as a duplicate of this bug. ***
Comment 2 Benda Xu gentoo-dev 2010-11-30 12:49:43 UTC
Created attachment 255939 [details, diff]
prefixify patch
Comment 3 Benda Xu gentoo-dev 2010-11-30 12:57:55 UTC
Here I submitted a patch to prefixify ROOT.

Another problem is that the libraries ROOT ships are in ${EPREFIX}/usr/lib/root. Which cannot be found by "root.exe" (called by "root") executable.

Upstream suggests[1] setting LD_LIBRARY_PATH explicitly, which is considered bad packaging practice. The upstream is very unfriendly with distributions. I guess we need to maintain patches.

To resolve this.

a. just put all the libraries of ROOT in ${EPREFIX}/usr/lib
b. tune LDFLAGS to let root executables look into ${EPREFIX}/usr/lib/root.

Which one is more acceptable for prefix?

1. e.g. http://root.cern.ch/drupal/content/how-use-use-python-pyroot-interpreter
Comment 4 Fabian Groffen gentoo-dev 2010-11-30 13:02:41 UTC
depending on how root is packaged today on Gentoo Linux, either of your options would be ok.  If Gentoo Linux uses the root dir, then we need to make sure the search path is extended to them.
Comment 5 Benda Xu gentoo-dev 2010-12-01 07:31:26 UTC
Created attachment 256011 [details, diff]
final
Comment 6 Benda Xu gentoo-dev 2010-12-01 07:34:32 UTC
Hi,

(In reply to comment #4)
> If Gentoo Linux uses the root dir, then we need to make sure the
> search path is extended to them.

With ABCD's advice, I have made a new patch to fix it.

Please review my patch. if it is okay to be included, this bug could be closed.

Yours,
Benda
Comment 7 Sébastien Fabbro (RETIRED) gentoo-dev 2011-03-16 21:09:40 UTC
newly bumped root-5.28.00b should be prefix ready. please test. thanks.
Comment 8 Benda Xu gentoo-dev 2011-04-28 09:19:43 UTC
Dear Sébastien, 

I have tested root-5.28.00b, it works. Thanks a lot!

There is one small issue remains: rpath

in prefix environment, ${EPREFIX}/usr/lib/root can not be searched at runtime by host or prefix default. We need to add rpath option when compiling. Fortunately, root provide such a mechanism via ./configure --enable-rpath.

Therefore I prepose the attached patch. (adding ~amd64-linux also)

(In reply to comment #7)
> newly bumped root-5.28.00b should be prefix ready. please test. thanks.
Comment 9 Benda Xu gentoo-dev 2011-04-28 09:20:54 UTC
Created attachment 271433 [details, diff]
enable rpath in prefix env, add ~amd64-linux keyword
Comment 10 Andrew Savchenko gentoo-dev 2011-08-02 22:30:34 UTC
Hello,

I merged your changes into root-5.30.00 ebuild from the science overlay.
Please test it out, thanks.
Comment 11 Benda Xu gentoo-dev 2011-12-10 03:41:58 UTC
(In reply to comment #10)

> I merged your changes into root-5.30.00 ebuild from the science overlay.
> Please test it out, thanks.

Hi, Andrew, I have tested =root-5.32* from science overlay on x86-linux. I works like a charm. Please consider keywording it.
Comment 12 Andrew Savchenko gentoo-dev 2011-12-11 01:47:44 UTC
Hello,

(In reply to comment #11)
> Hi, Andrew, I have tested =root-5.32* from science overlay on x86-linux. I
> works like a charm.

I'm glad to hear this :)

> Please consider keywording it.

Hmm, it already has ~amd64-linux keyword, or do you mean something else?
Comment 13 Benda Xu gentoo-dev 2011-12-11 08:37:31 UTC
(In reply to comment #12)
> > Please consider keywording it.
> 
> Hmm, it already has ~amd64-linux keyword, or do you mean something else?

I meant I have tested ~x86-linux, please keyword that also.

Good job and thank you! I think we can close this bug when >=root-5.32* migrates to gentoo-x86 tree.
Comment 14 Andrew Savchenko gentoo-dev 2011-12-11 21:40:25 UTC
I added ~x86-linux keyword in science overlay without version bump.
Comment 15 Fabian Groffen gentoo-dev 2011-12-12 07:42:57 UTC
(In reply to comment #14)
> I added ~x86-linux keyword in science overlay without version bump.

Pardon me, but when would you bump an ebuild for a keyword addition?
Comment 16 Andrew Savchenko gentoo-dev 2011-12-12 12:02:22 UTC
Hello,

(In reply to comment #15)
> Pardon me, but when would you bump an ebuild for a keyword addition?

If it is just for a keyword addition — never.

As far as I understand Gentoo ebuild policy, simple keyword addition is not a subject for a revision bump: http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=3&chap=1#doc_chap3
See "Versioning and revision bumps" paragraph.

There are no changes in the installed files or dependencies. Program behaviour and user experience will not be affected. The only affected are people using ~x86-linux prefix, they need to resync their tree anyway.
Comment 17 Sébastien Fabbro (RETIRED) gentoo-dev 2012-01-21 19:44:39 UTC
root-5.32 prefix clean now in tree. thanks!