Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 346741 - net-analyzer/cacti-0.8.7g with plugin-achitecture 2.9
Summary: net-analyzer/cacti-0.8.7g with plugin-achitecture 2.9
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2010-11-25 11:08 UTC by Jens Ott
Modified: 2017-12-20 00:48 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild of cacti-0.8.7g-r1 (introducing plugin-patch) (cacti-0.8.7g-r1.ebuild,2.18 KB, text/plain)
2010-11-25 11:10 UTC, Jens Ott
Details
Cacti-Plugins-Patch, modified to be work in Gentoo-Ebuild (cacti-plugin-0.8.7g-PA-v2.9.diff,137.22 KB, patch)
2010-11-25 11:10 UTC, Jens Ott
Details | Diff
Added the missing pa.sql to add neccessary tables to cacti-db in first-time install of plugin-architecture (Ausgabenaufstellung.xlsx,118 bytes, text/plain)
2010-12-14 19:54 UTC, Jens Ott
Details
SQL file to add tables for plugin-architecture (pa.sql,1.99 KB, text/plain)
2010-12-14 19:57 UTC, Jens Ott
Details
Added the missing pa.sql to add neccessary tables to cacti-db in first-time install of plugin-architecture (cacti-0.8.7g-r1.ebuild,2.22 KB, text/plain)
2010-12-14 20:04 UTC, Jens Ott
Details
Modified postinstall-en.txt to point on need to apply pa.sql (postinstall-en.txt,2.35 KB, text/plain)
2010-12-14 20:05 UTC, Jens Ott
Details
cacti-0.8.7h.ebuild.diff (cacti-0.8.7h.ebuild.diff,1.84 KB, patch)
2011-10-04 20:07 UTC, Alon Bar-Lev
Details | Diff
cacti-plugin-settings-0.5.ebuild (cacti-plugin-settings-0.5.ebuild,978 bytes, text/plain)
2011-10-04 21:49 UTC, Alon Bar-Lev
Details
cacti-plugin-thold-0.4.3.ebuild (cacti-plugin-thold-0.4.3.ebuild,986 bytes, text/plain)
2011-10-04 21:49 UTC, Alon Bar-Lev
Details
cacti-plugin-settings-0.5.ebuild (cacti-plugin-settings-0.5.ebuild,769 bytes, text/plain)
2011-10-22 18:38 UTC, Alon Bar-Lev
Details
cacti-plugin-thold-0.4.3.ebuild (cacti-plugin-thold-0.4.3.ebuild,777 bytes, text/plain)
2011-10-22 18:38 UTC, Alon Bar-Lev
Details
cacti-plugin-discovery-0.8.5.ebuild (cacti-plugin-discovery-0.8.5.ebuild,769 bytes, text/plain)
2011-10-22 18:39 UTC, Alon Bar-Lev
Details
cacti-plugin-monitor-0.8.2.ebuild (cacti-plugin-monitor-0.8.2.ebuild,769 bytes, text/plain)
2011-10-22 18:39 UTC, Alon Bar-Lev
Details
cacti-plugin-discovery-1.3.1.ebuild (cacti-plugin-discovery-1.3.1.ebuild,861 bytes, text/plain)
2011-11-06 12:10 UTC, Alon Bar-Lev
Details
cacti-plugin-monitor-1.3.0.1.ebuild (cacti-plugin-monitor-1.3.0.1.ebuild,860 bytes, text/plain)
2011-11-06 12:10 UTC, Alon Bar-Lev
Details
cacti-plugin-settings-0.71.0.1.ebuild (cacti-plugin-settings-0.71.0.1.ebuild,860 bytes, text/plain)
2011-11-06 12:11 UTC, Alon Bar-Lev
Details
cacti-plugin-thold-0.4.8.4.ebuild (cacti-plugin-thold-0.4.8.4.ebuild,839 bytes, text/plain)
2011-11-06 12:11 UTC, Alon Bar-Lev
Details
cacti-0.8.7i.ebuild.diff (cacti-0.8.7i.ebuild.diff,596 bytes, patch)
2011-12-13 16:34 UTC, Alon Bar-Lev
Details | Diff
cacti-plugin-discovery-1.3.1.ebuild (cacti-plugin-discovery-1.3.1.ebuild,885 bytes, text/plain)
2011-12-13 18:26 UTC, Alon Bar-Lev
Details
cacti-plugin-monitor-1.3.0.1.ebuild (cacti-plugin-monitor-1.3.0.1.ebuild,884 bytes, text/plain)
2011-12-13 18:26 UTC, Alon Bar-Lev
Details
cacti-plugin-settings-0.71.0.1.ebuild (cacti-plugin-settings-0.71.0.1.ebuild,884 bytes, text/plain)
2011-12-13 18:27 UTC, Alon Bar-Lev
Details
cacti-plugin-thold-0.4.9.3.ebuild (cacti-plugin-thold-0.4.9.3.ebuild,871 bytes, text/plain)
2011-12-13 18:27 UTC, Alon Bar-Lev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Ott 2010-11-25 11:08:00 UTC
As mentioned in Bug #324457 I ported the cacti-pluginarchitecture-patch to portage-version.
I added the USE-Flag "plugins" to make activation of this patch selectable.

For me it works fine ... but please when starting to use plugin-architecture, please start with some simple plugins like "tools" to check if it's working. I spent 3 days searching bugs in plugin-architecture-patch 2.9 to end up in finding that the plugin I used for testing had a stupid bug overwriting some variables ;-)
Comment 1 Jens Ott 2010-11-25 11:10:12 UTC
Created attachment 255393 [details]
Ebuild of cacti-0.8.7g-r1 (introducing plugin-patch)
Comment 2 Jens Ott 2010-11-25 11:10:59 UTC
Created attachment 255395 [details, diff]
Cacti-Plugins-Patch, modified to be work in Gentoo-Ebuild
Comment 3 Jens Ott 2010-12-14 19:54:27 UTC
Created attachment 257166 [details]
Added the missing pa.sql to add neccessary tables to cacti-db in first-time install of plugin-architecture
Comment 4 Jens Ott 2010-12-14 19:57:49 UTC
Created attachment 257168 [details]
SQL file to add tables for plugin-architecture
Comment 5 Jens Ott 2010-12-14 20:04:32 UTC
Created attachment 257170 [details]
Added the missing pa.sql to add neccessary tables to cacti-db in first-time install of plugin-architecture
Comment 6 Jens Ott 2010-12-14 20:05:47 UTC
Created attachment 257172 [details]
Modified postinstall-en.txt to point on need to apply pa.sql
Comment 7 Peter Volkov (RETIRED) gentoo-dev 2010-12-14 21:50:55 UTC
@infra, is it possible to remove Ausgabenaufstellung.xlsx attachment completely? It contains private information that was not supposed to appear here. If needed I can forward the user's request for you.
Comment 8 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-12-14 21:59:50 UTC
Attachment Ausgabenaufstellung.xlsx (id=257166) removed.
Comment 9 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-12-14 22:00:18 UTC
Removing infra.
Comment 10 Jens Ott 2010-12-14 22:35:01 UTC
Thanx guys!
Comment 11 Peter Volkov (RETIRED) gentoo-dev 2011-10-02 11:45:20 UTC
cacti-0.8.7h is in the tree but it looks like there is not development in plugin architecture since 2009. Am I correct? Does there exist/requreid patch for 0.8.7h? Is there any interest in having this in tree?
Comment 12 Alon Bar-Lev 2011-10-04 20:07:32 UTC
Created attachment 288795 [details, diff]
cacti-0.8.7h.ebuild.diff

Add plugin USE.

This is required to properly add cacti plugins to this base package.
Comment 13 Alon Bar-Lev 2011-10-04 20:08:55 UTC
(In reply to comment #11)
> cacti-0.8.7h is in the tree but it looks like there is not development in
> plugin architecture since 2009. Am I correct? Does there exist/requreid patch
> for 0.8.7h? Is there any interest in having this in tree?

No, it was released with 0.8.7 and required for all other plugins.
I don't understand why upstream did not merge this... it just make life more complex.

But, for us to be able to add plugins the base package must be patched.
Comment 14 Alon Bar-Lev 2011-10-04 21:49:14 UTC
Created attachment 288803 [details]
cacti-plugin-settings-0.5.ebuild
Comment 15 Alon Bar-Lev 2011-10-04 21:49:32 UTC
Created attachment 288805 [details]
cacti-plugin-thold-0.4.3.ebuild
Comment 16 Alon Bar-Lev 2011-10-04 21:53:13 UTC
I attached two plugin ebuilds.

There are few problems...

1. cacti specific - the downloads do not have version, so we probably need to rename and mirror at gentoo mirror.

2. webapp specific - there is no proper way and I found no example in tree for the webapp eclass to serve ebuild of a plugin to other ebuild. So I had to do this "by-hand".

3. webapp specific - there is no proper way to detect master package version, so I added the version hardcoded within the ebuild. Maybe this should be extracted from the package name and rename it to cact-plugin-0.8.7h-thold-0.4.3 - not sure it is leagal...
Comment 17 Alon Bar-Lev 2011-10-22 18:38:04 UTC
Created attachment 290547 [details]
cacti-plugin-settings-0.5.ebuild
Comment 18 Alon Bar-Lev 2011-10-22 18:38:33 UTC
Created attachment 290549 [details]
cacti-plugin-thold-0.4.3.ebuild
Comment 19 Alon Bar-Lev 2011-10-22 18:39:02 UTC
Created attachment 290551 [details]
cacti-plugin-discovery-0.8.5.ebuild
Comment 20 Alon Bar-Lev 2011-10-22 18:39:23 UTC
Created attachment 290553 [details]
cacti-plugin-monitor-0.8.2.ebuild
Comment 21 Alon Bar-Lev 2011-11-06 12:10:24 UTC
Created attachment 291811 [details]
cacti-plugin-discovery-1.3.1.ebuild
Comment 22 Alon Bar-Lev 2011-11-06 12:10:49 UTC
Created attachment 291813 [details]
cacti-plugin-monitor-1.3.0.1.ebuild
Comment 23 Alon Bar-Lev 2011-11-06 12:11:16 UTC
Created attachment 291815 [details]
cacti-plugin-settings-0.71.0.1.ebuild
Comment 24 Alon Bar-Lev 2011-11-06 12:11:36 UTC
Created attachment 291817 [details]
cacti-plugin-thold-0.4.8.4.ebuild
Comment 25 Alon Bar-Lev 2011-11-06 12:12:01 UTC
Cacti plugins have now versions at upstream!
Comment 26 Peter Volkov (RETIRED) gentoo-dev 2011-12-12 08:26:44 UTC
And cacti-0.8.7i with plugin architecture is in tree now! Thank you guys!
Comment 27 Alon Bar-Lev 2011-12-12 15:27:16 UTC
(In reply to comment #26)
> And cacti-0.8.7i with plugin architecture is in tree now! Thank you guys!

Are you sure? I don't see the new ebuild[1] patches anything.

[1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-analyzer/cacti/cacti-0.8.7i.ebuild?revision=1.1&view=markup
Comment 28 Jens Ott 2011-12-12 15:51:07 UTC
0.8.7I is available prepatched from upstream. PA finally made it into the core ;-)
Comment 29 Peter Volkov (RETIRED) gentoo-dev 2011-12-12 17:45:02 UTC
yup, Alon, just take a look and news item here:
http://www.cacti.net/

sunday, december 11th, 2011 - 10:35 pm
Cacti 0.8.7i released!!!

Now fully patched Cacti with Plugin Architecture available as well!!!
Comment 30 Alon Bar-Lev 2011-12-13 16:34:19 UTC
Created attachment 295689 [details, diff]
cacti-0.8.7i.ebuild.diff

No. This ebuild is without plugins.
Please reopen, attached is a working ebuild with plugins.
Comment 31 Alon Bar-Lev 2011-12-13 18:26:10 UTC
Created attachment 295715 [details]
cacti-plugin-discovery-1.3.1.ebuild
Comment 32 Alon Bar-Lev 2011-12-13 18:26:40 UTC
Created attachment 295717 [details]
cacti-plugin-monitor-1.3.0.1.ebuild
Comment 33 Alon Bar-Lev 2011-12-13 18:27:05 UTC
Created attachment 295719 [details]
cacti-plugin-settings-0.71.0.1.ebuild
Comment 34 Alon Bar-Lev 2011-12-13 18:27:31 UTC
Created attachment 295721 [details]
cacti-plugin-thold-0.4.9.3.ebuild
Comment 35 Peter Volkov (RETIRED) gentoo-dev 2011-12-14 05:13:17 UTC
Thank you, Alon. Do you know if there are any plans to merge codebases?
Comment 36 Alon Bar-Lev 2011-12-14 08:08:19 UTC
(In reply to comment #35)
> Thank you, Alon. Do you know if there are any plans to merge codebases?

Well, I don't know.
However there is a progress.
Instead of upstream provide base and patch, upstream provide two bases one without plugin and one pre-patched with plugin.

So it is kind of merge :)
Comment 37 Arnaud Launay 2012-02-12 11:44:37 UTC
Hmm, 0.8.6i has effectively two versions, so the USE=plugins should be easy to implement...