DEPEND is messed up USE="gtk gtk2" oh, So I get -both- versions of gtk+ installed? why? use gnome || myconf="${myconf}--enable-gnome_ui=no" there should be a space there if use gtk && use doc Why does this have "gtk" checked? bad behaviour. only use "doc" there.
Created attachment 21407 [details, diff] qa changes changed some stuff and fixed those bugs || ( gtk2? (...) gtk? (...) virtual/glibc ) is imo the best solution, because linphone can be build: 1. with gtk2 2. with gtk1 3. without gui at all (virtual/glibc) i hope you approve this :)
looks better, however it misses the case of USE="gtk gtk2" , as the tri-state will then depend on both, not only one of them (I assume they are mutualy exclusive The DEP tree for this sort of case is actually quite hairy :-/ roughly like this (never mind the versions, mind the logic ;) DEPEND=" gtk? ( gnome? ( gnome-base/gnome-panel gnome-base/libgnome gnome-base/libgnomeui ) !gnome? ( gtk2? ( >=x11-libs/gtk+-2.2 ) !gtk2 ( =x11-libs/gtk+-1.2* ) ) ) virtual/glibc" since if I've understood it right we have three GUI states: gtk 1.2 gtk 2.x gnome 2.x This will check gtk, if a user doesn't want a gtk ui, I doubt he wants a gnome one either, aye? gtk gnome depends on gtk 2.x not gnome check for gtk 2.x or 1.2 not gtk virtual/glibc since the gnome? dep pulls in gtk 2 anyhow.. (also, a version >=gnome-base/gnome-panel-2 is a good check, theres a 1.4 panel too, could cause weird conflicts )
btw.. never depend on alsa-driver, depen on alsa-lib, as alsa-driver can be provided anywhere (by a kernel, by the package , or perhaps the user has a hand-patched kernel with alsa in it? )
thx for your reply :) the alsa-driver thing will be fixed (seems like i missed that) actually you've got only two choices: 1st: without gnome you'll get the command-line version (linphonec) 2nd: with gnome (supports both versions), using gtk+-1 or gtk+-2 imo depend should more look like this: ... gnome? ( gnome-base/gnome-panel gnome-base/libgnome gnome-base/libgnomeui gtk2? ( >=x11-libs/gtk+-2 ) !gtk2? ( =x11-libs/gtk+-1.2* ) ) ... and silently drop the "gtk" use-flag which doesn't have any function... i'm doing some more test compiles ... btw, whats the preferred coding-style for "if use ... then" constructions ? atm i'm using "if [ `use bla` ]; then" ps.: if gtk+-1.2* shows up now during emerge -ep linphone, it's probably pulled in by imlib
... > gnome? ( > gnome-base/gnome-panel > gnome-base/libgnome > gnome-base/libgnomeui > gtk2? ( >=x11-libs/gtk+-2 ) > !gtk2? ( =x11-libs/gtk+-1.2* ) > ) Looks good, except that libgnome, libgnomeui both are gnome-2 only, no gnome 1.4 versions of those. (I think you refer to gnome-libs for the 1.4 version) So if there is gnome 1.4 and 2.x versions, you should separate those in the gtk2 USE flag. And version the gnome-panel as theres one version for 1.4 and one for 2.x, and you dont want "any version" , but specifically for the one you ask for.
as for if/then , I quite like the if [ ] then else style, its logical and simple.
A year has gone by. What is the current status of this ebuild?
Mass reassign, seems apparently unmaintained now. Unless someone picks this up, it should be better removed from the tree.
if no one is willing to maintain this I will fix these up soon. I am not interested in keeping it long-term though.
net-misc/linphone-1.0.1 is now in the tree under testing. Please try it out and let me know if you still have problems.
