diff attached.
Created attachment 253753 [details, diff] tar-1.2.5.diff
your call to eprefixy lacks quoting ... but why cant you rely on /bin/sh ? the script is so damn simple, i cant see this being an issue for portability. i dont like the -U hack ... plus, that should be append-cppflags. why not fix this correctly ?
(In reply to comment #2) > your call to eprefixy lacks quoting ... but why cant you rely on /bin/sh ? the > script is so damn simple, i cant see this being an issue for portability. Maybe /bin/sh would work there but the 2nd line is needed so both are changed at the same time. > i dont like the -U hack ... plus, that should be append-cppflags. why not fix > this correctly ? I'll have to leave this comment for grobian to answer.
this is only one `rmt`, so it'd be easier to simply change it to: exec rmt "$@"
- charset.alias removal probably can go, since our profiles should do that automatically these days - I can't find tar-1.25 in our (prefix) tree, so I currently don't understand where this comes from, the -U hack is likely no longer necessary Need to look into this later when I have more time.
Created attachment 253897 [details, diff] tar-1.2.5.diff - Made the "rmt" script simpler, dropped eprefixiy - Dropped -U hack for darwin - charset.alias is still removed. It is removed in gx86, so it is not a "prefix only" diff.
Created attachment 253913 [details, diff] tar-1.2.5.diff I would like to suggest the following patch, which is an improved version of Jeremy's patch.
i dont quite understand why everywhere you use EPREFIX, but then when creating the gtar symlink, you completely ignore it. the gtar symlink should just be in the same dir as the tar binary so that it's relative. the rest of the changes, while fine, are a bit obnoxious.
Created attachment 254401 [details, diff] tar-1.25.diff Improves upon the existing patches by making the gtar symlink relative, as requested. Since tar-1.25 has been p.masked since the origin of this bug, I will hold off on committing this until it is unmasked again. Unless someone objects in the meantime, but I think everything is covered now. Thanks.
well, that patch looks fine except you didnt answer my question: why dont you use EPREFIX in the creation of the symlink ? if EPREFIX is set to anything other than "/", there isnt going to be a "tar" in "/bin/" for you to symlink to.
Oh, sorry. I meant to explain that. The do* calls take $EPREFIX into account behind the scenes to minimize diffs generated between Gentoo Prefix and Gentoo Linux. http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=blob;f=bin/ebuild-helpers/dosym;h=bd4044f632ca9a37a0bfccbecc38995e20ed4abf;hb=refs/heads/prefix
thanks for the info ... obviously i had nfi feel free to merge your patch then
(In reply to comment #12) > feel free to merge your patch then Samuli unmasked tar-1.25, so I just committed the patch. Thanks for the review and assistance!
(In reply to comment #13) > (In reply to comment #12) > > > feel free to merge your patch then > > Samuli unmasked tar-1.25, so I just committed the patch. Thanks for the review > and assistance! > Ebuild/portage on two of my system (~amd64 and ~ppc32) does not agree with this euphemism(s), it states after II tar-1.25 # ebuild tar-1.25.ebuild unpack with an error, where the line ========================================= 32230 Abgebrochen | tar xof - ========================================= (Abgebrochen is german and means aborted) appears in all these logfiles app-mobilephone/obexftp-0.23-r1/temp/build.log dev-vcs/git-1.7.3.2-r1/temp/build.log dev-vcs/subversion-1.6.13/temp/build.log perl-core/Compress-Raw-Bzip2- 2.030/temp/build.log perl-core/Digest-MD5-2.51/temp/build.log perl-core/Storable-2.21/temp/build.log perl-core/Scalar-List-Utils-1.23/temp/build.log perl-c ore/ExtUtils-CBuilder-0.27.03/temp/build.log perl-core/Module-Build-0.36.07/temp/build.log perl-core/IO-Zlib-1.10/temp/build.log perl-core/IO-Compress-2.03 0/temp/build.log perl-core/File-Spec-3.33/temp/build.log perl-core/MIME-Base64-3.10/temp/build.log perl-core/Compress-Raw-Zlib-2.030/temp/build.log perl-co re/Archive-Tar-1.72/temp/build.log perl-core/Test-Harness-3.22/temp/build.log perl-core/ExtUtils-ParseXS-2.22.06/temp/build.log perl-core/Term-ANSIColor-3. 00/temp/build.log x11-libs/qt-sql-4.7.1/temp/build.log net-print/cups-1.4.4-r2/temp/build.log sys-apps/pv-1.1.4/temp/build.log dev-perl/Shell-EnvImporter-1 .07/temp/build.log dev-perl/Archive-Zip-1.30/temp/build.log dev-perl/Class-MethodMaker-2.16/temp/build.log dev-perl/IO-Socket-SSL-1.34/temp/build.log dev-p erl/Digest-SHA1-2.13/temp/build.log dev-perl/PortageXS-0.02.10-r1/temp/build.log dev-perl/XML-Parser-2.40/temp/build.log dev-perl/Crypt-SSLeay-0.58/temp/bu ild.log dev-perl/XML-SAX-0.96/temp/build.log dev-perl/Tie-IxHash-1.22/temp/build.log dev-perl/Text-Iconv-1.7/temp/build.log dev-perl/DBD-SQLite-1.31/temp/b uild.log dev-perl/XML-Twig-3.37/temp/build.log dev-perl/Authen-PAM-0.16/temp/build.log dev-perl/DelimMatch-1.06/temp/build.log dev-perl/Locale-gettext-1.05 -r1/temp/build.log dev-perl/URI-1.55/temp/build.log dev-perl/DBD-mysql-4.01.8/temp/build.log dev-perl/TermReadKey-2.30/temp/build.log dev-perl/Net-SSLeay-1 .36/temp/build.log dev-perl/XML-SAX-Writer-0.53/temp/build.log dev-perl/PlRPC-0.2020-r1/temp/build.log dev-perl/XML-Simple-2.18/temp/build.log dev-perl/Dig est-HMAC-1.02/temp/build.log dev-perl/DBI-1.615/temp/build.log dev-perl/XML-Generator-1.03/temp/build.log dev-perl/XML-LibXML-1.70/temp/build.log dev-perl/ HTML-Parser-3.67/temp/build.log dev-perl/HTML-Tree-4.1/temp/build.log dev-perl/XML-Filter-BufferText-1.01/temp/build.log dev-perl/XML-Handler-YAWriter-0.23 -r1/temp/build.log dev-perl/HTML-Tagset-3.20/temp/build.log dev-perl/libxml-perl-0.08/temp/build.log dev-perl/Net-SMTP-SSL-1.01/temp/build.log dev-perl/Err or-0.17.016/temp/build.log dev-perl/Net-Daemon-0.43/temp/build.log dev-perl/XML-XPath-1.13/temp/build.log dev-perl/XML-NamespaceSupport-1.11/temp/build.log dev-perl/Authen-SASL-2.15/temp/build.log dev-perl/libwww-perl-5.837/temp/build.log dev-perl/YAML-Tiny-1.44/temp/build.log media-libs/pdflib-7.0.4_p4-r1/te mp/build.log app-office/openoffice-3.2.1-r1/temp/build.log dev-python/librsvg-python-2.30.2/temp/build.log dev-python/gconf-python-2.28.1/temp/build.log me dia-gfx/imagemagick-6.6.5.6/temp/build.log www-client/elinks-0.12_pre5-r1/temp/build.log Geting some of them installed is possible if tar is a link to schily's star, but some switches there are unlike tar... Have alot of fun...
I don't understand. You will have to provide the proper info, like a build.log or something. Better yet, open a new bug. This bug report has nothing to do with your error, I feel. % ebuild tar-1.25.ebuild prepare * tar-1.25.tar.bz2 RMD160 SHA1 SHA256 size ;-) ... [ ok ] * checking ebuild checksums ;-) ... [ ok ] * checking auxfile checksums ;-) ... [ ok ] * checking miscfile checksums ;-) ... [ ok ] * checking tar-1.25.tar.bz2 ;-) ... [ ok ] * CPV: app-arch/tar-1.25 * REPO: gentoo * USE: elibc_glibc kernel_linux nls userland_GNU x86 >>> Unpacking source... >>> Unpacking tar-1.25.tar.bz2 to /var/tmp/portage/app-arch/tar-1.25/work >>> Source unpacked in /var/tmp/portage/app-arch/tar-1.25/work >>> Preparing source in /var/tmp/portage/app-arch/tar-1.25/work/tar-1.25 ... >>> Source prepared.
(In reply to comment #15) > I don't understand. You will have to provide the proper info, like a build.log > or something. Better yet, open a new bug. This bug report has nothing to do > with your error, I feel. > > % ebuild tar-1.25.ebuild prepare > * tar-1.25.tar.bz2 RMD160 SHA1 SHA256 size ;-) ... [ ok ] > * checking ebuild checksums ;-) ... [ ok ] > * checking auxfile checksums ;-) ... [ ok ] > * checking miscfile checksums ;-) ... [ ok ] > * checking tar-1.25.tar.bz2 ;-) ... [ ok ] > * CPV: app-arch/tar-1.25 > * REPO: gentoo > * USE: elibc_glibc kernel_linux nls userland_GNU x86 > >>> Unpacking source... > >>> Unpacking tar-1.25.tar.bz2 to /var/tmp/portage/app-arch/tar-1.25/work > >>> Source unpacked in /var/tmp/portage/app-arch/tar-1.25/work > >>> Preparing source in /var/tmp/portage/app-arch/tar-1.25/work/tar-1.25 ... > >>> Source prepared. > Sorry, I couldn't resist: You unpack this 1.25-Version of tar with which tar-Version..? The above cited Error-msgs were during a refdep-rebuild, during the emerge --sync the tar-1.25-version was installed and unpacked from the tar-1.24-version... As far as I know, packages compressed with the 'usual' compressors - bzip2, compress gzip and alike are well handled from star respective from the scripts, other packers need some interventions. wbr oas
