Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 342643 - app-backup/rsnapshot tries to use dev-perl/Lchown if present
Summary: app-backup/rsnapshot tries to use dev-perl/Lchown if present
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal with 1 vote (vote)
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 467160
Blocks:
  Show dependency tree
 
Reported: 2010-10-25 15:18 UTC by Justin Lecher (RETIRED)
Modified: 2013-04-25 07:16 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2010-10-25 15:18:57 UTC
# rsnapshot -D du /tmp
require Lchown
Lchown module not found
ERROR: Permission denied


which can be fixed when dev-perl/Lchown is installed.
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-10-25 18:51:06 UTC
        if ($@) {
                $have_lchown = 0;
                
                if ($verbose >= 5) {
                        print_msg('Lchown module not found', 5);
                }
                
                return(0);
        }
        

it doesn't seem like it should be needed, it's actually loaded at runtime if present; does that -D enable perl debugging?
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2010-10-25 19:11:52 UTC
Actually there is no good debugging output as far as I saw. I was playing around to get used to it, and wanted some more verbose output, which I didn't got beyond -V.
Nevertheless there should be a USE-dep or a real DEP on it, otherwise we have some automaGics here.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-10-25 19:27:06 UTC
The way Perl, Python, Ruby and most other interpreted languages work, automatic deps _are_ part of the game… so are the autodetected dlopen()-based dependencies in C (much less in C++). You confuse it with automagic (it's found, and linked to, and will fail if it gets removed).

On the other hand the Lchown dependency would still help.

Comment 4 Daniel Robbins 2011-07-20 17:44:46 UTC
FYI, I've added dev-perl/Lchown as an RDEPEND to Funtoo's ebuild. If not addressed, rsnapshot will typically return non-zero error codes which indicate backup failure: https://github.com/funtoo/funtoo-overlay/commit/86b531303669361db84cc4db67661b90269f86a3
Comment 5 Jon Gerdes 2011-10-13 08:27:44 UTC
Without Lchown then you get lots of these sorts of problems, which are logged (if you turn the logfile on):

[13/Oct/2011:08:59:21] WARNING: Could not lchown() symlink "/backup/rsnapshot/daily.1/<FILE_NAME>"

This error is covered here: http://rsnapshot.org/faq.html (Q: 	I get warnings like Could not lchown() symlink. Help?)

I emerged dev-perl/Lchown and the errors go away.

I don't think a USE flag is needed because it seems to be part of the core functionality.  Without it you get warnings and symlinks will potentially have the wrong permissions. 

It is not a build time dependency - rsnapshot builds OK without it.

Unless there's a good reason not to, please add that package as an RDEPEND.
Comment 6 Homer 2013-04-25 03:22:56 UTC
Bump.

I just hit this too (app-backup/rsnapshot-1.3.1-r1): "WARNING: Could not lchown() symlink" ... etc.

+1 RDEPEND dev-perl/Lchown.
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2013-04-25 07:16:56 UTC
+*rsnapshot-1.3.1-r2 (25 Apr 2013)
+
+  25 Apr 2013; Justin Lecher <jlec@gentoo.org> +rsnapshot-1.3.1-r2.ebuild:
+  Add dev-perl/Lchown as dep, #342643
+