Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 340425 - sys-block/open-iscsi-2.0.872 available
Summary: sys-block/open-iscsi-2.0.872 available
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://git.kernel.org/?p=linux/kernel...
Whiteboard:
Keywords:
Depends on:
Blocks: 307619
  Show dependency tree
 
Reported: 2010-10-10 21:17 UTC by Stefan Behte (RETIRED)
Modified: 2011-08-16 18:32 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
open-iscsi-2.0.872-glibc212.patch (open-iscsi-2.0.872-glibc212.patch,266 bytes, patch)
2010-10-10 21:17 UTC, Stefan Behte (RETIRED)
Details | Diff
open-iscsi-2.0.872-makefile-cleanup.patch (open-iscsi-2.0.872-makefile-cleanup.patch,839 bytes, patch)
2010-10-10 21:18 UTC, Stefan Behte (RETIRED)
Details | Diff
open-iscsi-2.0.872.ebuild (open-iscsi-2.0.872.ebuild,2.55 KB, text/plain)
2010-10-10 21:18 UTC, Stefan Behte (RETIRED)
Details
diff between 2.0.871.3 and 2.0.872 (p,1007 bytes, patch)
2010-10-10 21:20 UTC, Stefan Behte (RETIRED)
Details | Diff
diff between 2.0.871.3 and 2.0.872 v2 (open-iscsi-2.0.871.3-to-2.0.872.diff,2.69 KB, patch)
2011-05-30 23:50 UTC, Sebastian Pipping
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Behte (RETIRED) gentoo-dev Security 2010-10-10 21:17:30 UTC
sys-block/open-iscsi-2.0.872 is available, ibft does not work for me with 2.0.871.
Comment 1 Stefan Behte (RETIRED) gentoo-dev Security 2010-10-10 21:17:52 UTC
Created attachment 250163 [details, diff]
open-iscsi-2.0.872-glibc212.patch
Comment 2 Stefan Behte (RETIRED) gentoo-dev Security 2010-10-10 21:18:09 UTC
Created attachment 250165 [details, diff]
open-iscsi-2.0.872-makefile-cleanup.patch
Comment 3 Stefan Behte (RETIRED) gentoo-dev Security 2010-10-10 21:18:49 UTC
Created attachment 250167 [details]
open-iscsi-2.0.872.ebuild
Comment 4 Stefan Behte (RETIRED) gentoo-dev Security 2010-10-10 21:20:25 UTC
Created attachment 250169 [details, diff]
diff between 2.0.871.3 and 2.0.872
Comment 5 Stefan Behte (RETIRED) gentoo-dev Security 2010-10-10 21:38:39 UTC
It fixes a bunch of problems:
http://git.kernel.org/?p=linux/kernel/git/mnc/open-iscsi.git;a=blob;f=Changelog;h=c1df8bd10ed9198453957529190f90063746af2d;hb=c1df8bd10ed9198453957529190f90063746af2d

Scripts from #307619 could be added with this.
Comment 6 Rob MacKinnon 2010-12-27 20:31:41 UTC
FYI, When building on amd64/x86_64, 2.0.872 fails when linking libisns.a to slp.o...

--- begin trimmed ebuild ---
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking whether byte ordering is bigendian... no
checking how to run the C preprocessor... gcc -E
checking for a BSD-compatible install... /usr/bin/install -c
checking whether ln -s works... yes
checking whether make sets $(MAKE)... yes
checking for sh... /bin/sh
checking for inline... inline
checking for ANSI C header files... (cached) yes
checking for sys/wait.h that is POSIX.1 compatible... yes
checking errno.h usability... yes
checking errno.h presence... yes
checking for errno.h... yes
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking malloc.h usability... yes
checking malloc.h presence... yes
checking for malloc.h... yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for strings.h... (cached) yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking locale.h usability... yes
checking locale.h presence... yes
checking for locale.h... yes
checking getopt.h usability... yes
checking getopt.h presence... yes
checking for getopt.h... yes
checking for socket in -lsocket... no
checking for getopt_long... yes
checking openssl/crypto.h usability... yes
checking openssl/crypto.h presence... yes
checking for openssl/crypto.h... yes
checking for EVP_PKEY_new in -lcrypto... yes
checking slp.h usability... yes
checking slp.h presence... yes
checking for slp.h... yes
checking for SLPOpen in -lslp... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: WARNING:  'Makefile.in' seems to ignore the --datarootdir setting
config.status: creating config.h
.
.
.
cc  -O2 -pipe -Wall -Wstrict-prototypes -I../include -I. -I../utils/open-isns -DLinux -DNETLINK_ISCSI=8 -D_GNU_SOURCE -Wl,-O1 -Wl,--as-needed iscsi_util.o io.o auth.o login.o log.o md5.o sha1.o iface.o idbm.o sysfs.o host.o session_info.o iscsi_sysfs.o iscsi_net_util.o iscsid_req.o ../utils/sysdeps/sysdeps.o netlink.o initiator.o scsi.o actor.o event_poll.o mgmt_ipc.o transport.o cxgb3i.o be2iscsi.o ../utils/fwparam_ibft/fw_entry.o ../utils/fwparam_ibft/fwparam_ppc.o ../utils/fwparam_ibft/fwparam_sysfs.o ../utils/fwparam_ibft/prom_lex.o ../utils/fwparam_ibft/prom_parse.tab.o strings.o discovery.o iscsid.o session_mgmt.o discoveryd.o -o iscsid -L../utils/open-isns -lisns -lcrypto
login.o: In function `resolve_address':
login.c:(.text+0x119a): warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
../utils/open-isns/libisns.a(slp.o): In function `isns_slp_register':
slp.c:(.text+0x41): undefined reference to `SLPOpen'
slp.c:(.text+0x9f): undefined reference to `SLPReg'
slp.c:(.text+0xae): undefined reference to `SLPClose'
../utils/open-isns/libisns.a(slp.o): In function `isns_slp_unregister':
slp.c:(.text+0x128): undefined reference to `SLPOpen'
slp.c:(.text+0x16b): undefined reference to `SLPDereg'
slp.c:(.text+0x17a): undefined reference to `SLPClose'
../utils/open-isns/libisns.a(slp.o): In function `isns_slp_url_callback':
slp.c:(.text+0x256): undefined reference to `SLPParseSrvURL'
slp.c:(.text+0x364): undefined reference to `SLPFree'
../utils/open-isns/libisns.a(slp.o): In function `isns_slp_find':
slp.c:(.text+0x3c8): undefined reference to `SLPOpen'
slp.c:(.text+0x416): undefined reference to `SLPFindSrvs'
slp.c:(.text+0x425): undefined reference to `SLPClose'
collect2: ld returned 1 exit status
make[1]: *** [iscsid] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/sys-block/open-iscsi-2.0.872/work/open-iscsi-2.0-872/usr'
make: *** [user] Error 2
emake failed
--- end errors --


emerge --info
Portage 2.1.9.26 (hardened/linux/amd64, gcc-4.4.4, glibc-2.12.1-r3, 2.6.34-gentoo-r12 x86_64)
=================================================================
System uname: Linux-2.6.34-gentoo-r12-x86_64-Intel-R-_Xeon-R-_CPU_X3323_@_2.50GHz-with-gentoo-2.0.1
Timestamp of tree: Mon, 27 Dec 2010 01:45:02 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:     4.1_p9
dev-lang/python:     2.6.5-r3, 2.7.1, 3.1.3
dev-util/cmake:      2.8.3
sys-apps/baselayout: 2.0.1-r1
sys-apps/openrc:     0.6.8
sys-apps/sandbox:    2.4
sys-devel/autoconf:  2.68
sys-devel/automake:  1.11.1
sys-devel/binutils:  2.20.1-r1, 2.21
sys-devel/gcc:       4.4.4-r2, 4.5.1-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.4-r1
sys-devel/make:      3.81-r2
virtual/os-headers:  2.6.36.1 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/locale.gen /etc/localtime /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs buildpkg distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_US"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages/x86_64/"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/seagull"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="a52 aac acl acpi ads amd64 audit autoipd avahi bash-completion berkdb bzip2 caps cdr chm cjk cli cracklib crypt cups curl cvs cxx dbus device-mapper dhcpcd disk-partition divx dmraid dri dts dv dvd dvdr exif expat ext3 ext4 faad fam fat fbcon fbsplash flac fuse gcj gcrypt gd gdbm gif glibc gmp gnutls gphoto2 gpm hardened hddtemp hdri hfs howl-compat iconv idn inotify iproute2 ipv6 iscsi jfs jpeg jpeg2k justify kerberos laptop lcms ldap libnotify libssh2 lm_sensors logrotate lzma lzo md5sum mdadm mdnsresponder-compat mikmod mmap mmx mng modules mp2 mp3 mp4 mpeg mudflap multilib multislot multiuser mysql ncurses networking networkmanager nfs nis nls nptl nptl-only nptlonly nss ntfs ntp objc objc++ objc-gc ogg openal openexr openmp pam pccts pcre pdf perl pic png pppd pst python python3 quicktime rar raw readline reiser4 reiserfs resolvconf rtc samba sasl scsi session slp snmp sqlite sqlite3 sse sse2 sse2; ssl subversion svg swig sysfs syslog system-sqlite tcl tcpd threads tiff udev unicode urandom usb vcd wav wmf x264 xattr xfs xml xmp xorg xvid zeroconf zlib" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" INPUT_DEVICES="mouse keyboard evdev synaptics virtualbox joystick wacom aiptek vmmouse" KERNEL="linux" LINGUAS="en en_US" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="svga vesa glint virtualbox v4l nouveau nv radeon radeonhd intel via fbdev" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 7 Sebastian Schwardt 2011-01-02 12:45:50 UTC
(In reply to comment #6)
> FYI, When building on amd64/x86_64, 2.0.872 fails when linking libisns.a to
> slp.o...
> 

missing openslp as dependency, add it in ebuild file, rebuild digest and it should work, at least with net-libs/openslp-1.2.1-r1 
Comment 8 Daniel Heule 2011-01-04 23:53:52 UTC
This version is needed for all kernels >=2.6.36 
see
http://git.kernel.org/?p=linux/kernel/git/mnc/open-iscsi.git;a=commitdiff;h=f0b670c016c85c882bb0583eaef8ea2f7147d4af

please put it to the tree, at least as unstable ;-)
Comment 9 Kazuhiro Sakai 2011-03-01 10:00:49 UTC
Bump. Please put it to the tree.

Thanks in advance.
Comment 10 Fabio Erculiani (RETIRED) gentoo-dev 2011-03-22 14:06:56 UTC
Please also merge the patches at:
http://gitweb.sabayon.org/?p=overlay.git;a=commit;h=33f4e346a3b584eff8453e56477a62d459e5e50b

openslt is an automagic dependency.
Comment 11 Sebastian Pipping gentoo-dev 2011-03-23 14:06:16 UTC
Re-assigning to herd due to this content in metadata.xml

  [..]
  <herd>base-system</herd>
  <maintainer>
    <email>kingtaco@gentoo.org</email>
  </maintainer>
  [..]

In case of no reply until 2011-03-30 I may touch this ebuild myself.
Comment 12 Doug Goldstein (RETIRED) gentoo-dev 2011-04-08 16:00:13 UTC
Sebastian,

Feel free to update this package. Please incorporate all the various fixes in the different tickets as well. It'd be much appreciated by Mike Doty & the base-system team.
Comment 13 Krzysiek 2011-05-30 21:09:39 UTC
Is there any progress on this?
Comment 14 Sebastian Pipping gentoo-dev 2011-05-30 23:50:50 UTC
Created attachment 275243 [details, diff]
diff between 2.0.871.3 and 2.0.872 v2

Please test the ebuild just added to overlay betagarden and report back.
After that, this may go into the main tree.

Changes to where we were before:
- new use flag slp (with build+run dependency on net-libs/openslp)
- call configure ourselves, was called by make before (from lxnay/genkernel)
- fix search location of kernel makefile
- respect LDFLAGS on /usr/sbin/iscsi-iname, too
- add a bunch of "|| die"s
Comment 15 Sebastian Pipping gentoo-dev 2011-05-30 23:58:23 UTC
PS: Initscript is taken from bug #307619.  Making us a blocker to bug #307619.
Comment 16 Sebastian Pipping gentoo-dev 2011-06-05 11:47:56 UTC
I would like to have at least one of you test this before moving it into the Gentoo tree.  Anyone?
Comment 17 Sebastian Pipping gentoo-dev 2011-06-07 14:36:45 UTC
+*open-iscsi-2.0.872 (07 Jun 2011)
+
+  07 Jun 2011; Sebastian Pipping <sping@gentoo.org> +open-iscsi-2.0.872.ebuild,
+  +files/open-iscsi-2.0.872-conf.d,
+  +files/open-iscsi-2.0.872-dont-call-configure.patch,
+  +files/open-iscsi-2.0.872-glibc212.patch, +files/open-iscsi-2.0.872-init.d,
+  +files/open-iscsi-2.0.872-ldflags.patch,
+  +files/open-iscsi-2.0.872-makefile-cleanup.patch:
+  Bump to 2.0.872 (bug #340425)
+
Comment 18 404 Error 2011-06-13 00:20:49 UTC
Sebastian, on Linux 3.0 (testd on -rc2) the ebuild fails on the kernel version requirement:

* Found kernel source directory:
*     /usr/src/linux
* Found sources for kernel version:
*     3.0.0-rc2-kms
* ERROR: sys-block/open-iscsi-2.0.872 failed:
*   Sorry, your kernel must be 2.6.16-rc5 or newer!

Could I suggest to do the following change:

 pkg_setup() {
        linux-info_pkg_setup
 
-       if [ $KV_PATCH -lt 15 ]; then
+       if [ kernel_is le 2 6 15 ]; then
                die "Sorry, your kernel must be 2.6.16-rc5 or newer!"
        fi

Compiles like a charm once applied :)
Comment 19 Sebastian Pipping gentoo-dev 2011-06-13 01:47:53 UTC
(In reply to comment #18)
> Sebastian, on Linux 3.0 (testd on -rc2) the ebuild fails on the kernel version
> requirement:

Good catch, thanks for reporting.


> -       if [ $KV_PATCH -lt 15 ]; then
> +       if [ kernel_is le 2 6 15 ]; then

Thanks for pointing to function kernel_is.  With kernel_is the braces need to go though, as of my understanding.  So I have now patched it to this:

  if kernel_is -lt 2 6 16; then
    die "Sorry, your kernel must be 2.6.16-rc5 or newer!"
  fi

On last comment: please open a new bug next time to easy up tracking.  Re-opening this bug wouldn't be proper and leaving it closed makes tracking hard to impossible.  Still, thanks for speaking up!

+  13 Jun 2011; Sebastian Pipping <sping@gentoo.org>
+  open-iscsi-2.0.870.3-r1.ebuild, open-iscsi-2.0.871.ebuild,
+  open-iscsi-2.0.871-r1.ebuild, open-iscsi-2.0.871.3.ebuild,
+  open-iscsi-2.0.872.ebuild:
+  Fix version check for Linux 3
+
Comment 20 Stefan Behte (RETIRED) gentoo-dev Security 2011-08-16 15:07:55 UTC
Sebastian, can you please put it into unstable now?
Comment 21 Sebastian Pipping gentoo-dev 2011-08-16 18:32:35 UTC
+  16 Aug 2011; Sebastian Pipping <sping@gentoo.org> package.mask:
+  Unmask sys-block/open-iscsi-2.0.872 as requested (bug #340425)
+