Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 339032 - app-cdr/k3b-2.0.1: make hal optional
Summary: app-cdr/k3b-2.0.1: make hal optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo KDE team
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard:
Keywords:
Depends on:
Blocks: 313389
  Show dependency tree
 
Reported: 2010-09-28 13:49 UTC by Christoph Junghans (RETIRED)
Modified: 2011-01-24 08:29 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to make hal optional (k3b-2.0.0-remove-hal.patch,936 bytes, patch)
2010-09-28 13:50 UTC, Christoph Junghans (RETIRED)
Details | Diff
patch for k3b-2.0.0.ebuild (k3b-2.0.0.ebuild.patch,1.81 KB, patch)
2010-09-28 13:51 UTC, Christoph Junghans (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2010-09-28 13:49:57 UTC
k3b depends hard on hal, which is not needed in the case of non-removable drives and/or kde's solid hardware detection.
Comment 1 Christoph Junghans (RETIRED) gentoo-dev 2010-09-28 13:50:38 UTC
Created attachment 248902 [details, diff]
patch to make hal optional
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2010-09-28 13:51:21 UTC
Created attachment 248903 [details, diff]
patch for k3b-2.0.0.ebuild
Comment 3 Christoph Junghans (RETIRED) gentoo-dev 2010-09-28 13:54:15 UTC
If you quickly want test it, there is k3b-2.0.0-r1 in the cj-overlay.
Comment 4 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2010-10-06 11:39:01 UTC
The patch seems good, but we will apply it only if upstream accepts it first, so please file an upstream bug and add the url here too
Comment 5 Christoph Junghans (RETIRED) gentoo-dev 2010-10-06 12:24:16 UTC
Reported to kde bug tracker: bug #253388
Comment 6 dE 2010-10-08 13:13:19 UTC
Well, I was thing hal is completely optional, it's listed in the optional dependencies as of now.
Comment 7 Mads 2010-12-08 11:36:06 UTC
Does anyone else get a segfault when starting k3b 2.0.1 with hal disabled?
Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2010-12-19 12:01:17 UTC
I'd really like to know the reason behind this patch. All it does is making k3b unable to find any burning devices. k3b even reports this at startup and suggests to install/enable hal.
Comment 9 Patrizio Bassi 2010-12-19 12:19:00 UTC
lars is right. just remove the dep but it's not working....we need code to manage devices.
Comment 10 Christoph Junghans (RETIRED) gentoo-dev 2010-12-19 14:41:57 UTC
(In reply to comment #8)
> I'd really like to know the reason behind this patch. All it does is making k3b
> unable to find any burning devices. k3b even reports this at startup and
> suggests to install/enable hal.
The hardware detection of k3b[-hal] works as long as kde-base/solid[hal] is installed, so the above patch only removes the direct depends on hal, solid still needs hal. This combination works on my x86 machine with a usb dvd-device.

My next step is to look into Fedora's DeviceKit backend for kde-base/solid:4.4 to gentoo, which allows us to get rid of hal in solid, but I haven't had the time to do that yet.
Comment 11 Marian Kyral 2010-12-26 19:23:53 UTC
Maybe someone will know.

After update KDE to 4.5.90 (4.6 rc1), K3b no longer recognize optical drives:

No optical drive found.
K3b did not find any optical device in your system.
Solution: Make sure HAL daemon is running, it is used by K3b for finding devices.

I'm not sure whether it is cause by change on HAL or solid.

I'm testing the latest git version.
Comment 12 Christoph Junghans (RETIRED) gentoo-dev 2010-12-26 23:06:50 UTC
@tampakrap: Patch was accepted upstream!
Comment 13 Christoph Junghans (RETIRED) gentoo-dev 2010-12-27 16:53:25 UTC
(In reply to comment #11)
> Maybe someone will know.
> 
> After update KDE to 4.5.90 (4.6 rc1), K3b no longer recognize optical drives:
> I'm not sure whether it is cause by change on HAL or solid.
Does kde recognize usb-sticks and usb cd-drives when hal is not running?
Comment 14 Marian Kyral 2010-12-27 18:11:10 UTC
(In reply to comment #13)
> (In reply to comment #11)
> > Maybe someone will know.
> > 
> > After update KDE to 4.5.90 (4.6 rc1), K3b no longer recognize optical drives:
> > I'm not sure whether it is cause by change on HAL or solid.
> Does kde recognize usb-sticks and usb cd-drives when hal is not running?
> 

Yes,

plasma-desktop(3715)/libplasma Plasma::DataContainer::checkUsage: "/org/freedesktop/UDisks/devices/sdb1" is unused
plasma-desktop(3715)/plasma Notifier::DeviceNotifier::deviceAdded: DeviceNotifier:: source added "/org/freedesktop/UDisks/devices/sdb1"
kded(3595) DeviceAutomounter::automountDevice: Saving as "Verbatim_2G"
kded(3595) AutomounterSettings::shouldAutomountDevice: Processing "/org/freedesktop/UDisks/devices/sdb1"
kded(3595) AutomounterSettings::shouldAutomountDevice: type: 1
kded(3595) AutomounterSettings::shouldAutomountDevice: typeCondition: false
kded(3595) AutomounterSettings::shouldAutomountDevice: automountKnownDevices: false
kded(3595) AutomounterSettings::shouldAutomountDevice: deviceIsKnown: true
kded(3595) AutomounterSettings::shouldAutomountDevice: AutomountEnabled: true
kded(3595) AutomounterSettings::shouldAutomountDevice: Automount: false
kded(3595) AutomounterSettings::shouldAutomountDevice: LastSeenMounted: false
kded(3595) AutomounterSettings::shouldAutomountDevice: ShouldAutomount: false
kded(3595)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig:
plasma-desktop(3715)/plasma Notifier::DeviceItem::setLeftAction: setting to 0
[/usr/bin/nepomukservicestub] nepomukremovablestorageservice(4007) Nepomuk::RemovableStorageService::createCacheEntry: Found removable storage volume for Nepomuk docking: "/org/freedesktop/UDisks/devices/sdb1" "Verbatim_2G"
Comment 15 Patrizio Bassi 2010-12-27 18:13:11 UTC
for me it crashes on startup, with or without hal.


Application: K3b (k3b), signal: Segmentation fault
[Current thread is 1 (Thread 0x7f84a0087760 (LWP 11467))]

Thread 4 (Thread 0x7f848b792710 (LWP 11468)):
#0  0x00007f849a5ea0f3 in select () from /lib/libc.so.6
#1  0x00007f849b9c455e in qt_safe_select(int, fd_set*, fd_set*, fd_set*, timeval const*) () from /usr/lib64/qt4/libQtCore.so.4
#2  0x00007f849b9c7c60 in QEventDispatcherUNIXPrivate::doSelect(QFlags<QEventLoop::ProcessEventsFlag>, timeval*) () from /usr/lib64/qt4/libQtCore.so.4
#3  0x00007f849b9c883b in QEventDispatcherUNIX::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/qt4/libQtCore.so.4
#4  0x00007f849b999be2 in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/qt4/libQtCore.so.4
#5  0x00007f849b999fc4 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/qt4/libQtCore.so.4
#6  0x00007f849b8a68bd in QThread::exec() () from /usr/lib64/qt4/libQtCore.so.4
#7  0x00007f849b979dd8 in ?? () from /usr/lib64/qt4/libQtCore.so.4
#8  0x00007f849b8a95de in ?? () from /usr/lib64/qt4/libQtCore.so.4
#9  0x00007f849a2f59f1 in start_thread () from /lib/libpthread.so.0
#10 0x00007f849a5f16cd in clone () from /lib/libc.so.6

Thread 3 (Thread 0x7f8485f31710 (LWP 11469)):
#0  0x00007f849a5ea0f3 in select () from /lib/libc.so.6
#1  0x00007f849b97768c in ?? () from /usr/lib64/qt4/libQtCore.so.4
#2  0x00007f849b8a95de in ?? () from /usr/lib64/qt4/libQtCore.so.4
#3  0x00007f849a2f59f1 in start_thread () from /lib/libpthread.so.0
#4  0x00007f849a5f16cd in clone () from /lib/libc.so.6

Thread 2 (Thread 0x7f8485730710 (LWP 11486)):
#0  0x00007f849a5ea0f3 in select () from /lib/libc.so.6
#1  0x00007f849f9612a7 in ?? () from /usr/lib/libk3blib.so.6
#2  0x00007f849b8a95de in ?? () from /usr/lib64/qt4/libQtCore.so.4
#3  0x00007f849a2f59f1 in start_thread () from /lib/libpthread.so.0
#4  0x00007f849a5f16cd in clone () from /lib/libc.so.6

Thread 1 (Thread 0x7f84a0087760 (LWP 11467)):
[KCrash Handler]
#6  0x00007f849e75a674 in Solid::Block::device() const () from /usr/lib/libsolid.so.4
#7  0x00007f849fc9adfd in K3b::Device::DeviceManager::addDevice(Solid::Device const&) () from /usr/lib/libk3bdevice.so.6
#8  0x000000000053bfdd in _start ()
Comment 16 Marian Kyral 2010-12-27 18:25:51 UTC
$ udisk --dump:

Showing information for /org/freedesktop/UDisks/devices/sr0
  native-path:                 /sys/devices/pci0000:00/0000:00:1f.2/host1/target1:0:0/1:0:0:0/block/sr0
  device:                      11:0
  device-file:                 /dev/sr0
    presentation:              /dev/sr0
    by-path:                   /dev/disk/by-path/pci-0000:00:1f.2-scsi-1:0:0:0
  detected at:                 Po 27. prosinec 2010, 08:10:10 CET
  system internal:             0
  removable:                   1
  has media:                   0
    detects change:            1
    detection by polling:      1
    detection inhibitable:     1
    detection inhibited:       0
  is read only:                0
  is mounted:                  0
  mount paths:             
  mounted by uid:              0
  presentation hide:           0
  presentation nopolicy:       0
  presentation name:           
  presentation icon:           
  size:                        0
  block size:                  0
  job underway:                no
  usage:                       
  type:                        
  version:                     
  uuid:                        
  label:                       
  drive:
    vendor:                    TSSTcorp
    model:                     DVD+-RW TS-U633A
    revision:                  D300
    serial:                    
    WWN:                       
    detachable:                0
    can spindown:              0
    rotational media:          Yes, unknown rate
    write-cache:               unknown
    ejectable:                 1
    adapter:                   /org/freedesktop/UDisks/adapters/0000_3a00_3a1f_2e2
    ports:
      /org/freedesktop/UDisks/adapters/0000_3a00_3a1f_2e2/host1
    similar devices:
    media:                     
      compat:                  optical_cd optical_cd_r optical_cd_rw optical_dvd optical_dvd_r optical_dvd_ram optical_mrw optical_mrw_w
    interface:                 scsi
    if speed:                  (unknown)
    ATA SMART:                 not available
Comment 17 Marian Kyral 2010-12-28 11:13:26 UTC
So it is tricky - there have to be blank CD in drive. Then K3B recognize it. But anyway, k3b is crashing at start of burning :-( 
https://bugs.kde.org/show_bug.cgi?id=261439
Comment 18 Dror Levin (RETIRED) gentoo-dev 2011-01-16 23:17:39 UTC
K3b is now bumped to version 2.0.2 which has hal support optional. I preferred to simply remove the hal dep and not introduce a new USE flag, but it can be added if there is demand.

Note that KDE 4.6 will soon be released, which also does not need hal anymore.
Comment 19 Rafael 2011-01-23 23:44:50 UTC
(In reply to comment #18)
> K3b is now bumped to version 2.0.2 which has hal support optional. I preferred
> to simply remove the hal dep and not introduce a new USE flag, but it can be
> added if there is demand.
> 
> Note that KDE 4.6 will soon be released, which also does not need hal anymore.
> 

I've just tried 2.0.2 and it doesn't work without hal. So, what's the point of removing the dependency if K3b still needs hal to detect the burning device?
Comment 20 Christoph Junghans (RETIRED) gentoo-dev 2011-01-24 08:29:12 UTC
(In reply to comment #19)
> I've just tried 2.0.2 and it doesn't work without hal. So, what's the point of
> removing the dependency if K3b still needs hal to detect the burning device?
k3b uses solid for device detection, which depends on hal. In kde 4.6 solid will be able to detect devices through udev (without hal).