Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 337903 - net-misc/sipcalc _FORTIFY_SOURCE indicates presence of overflow
Summary: net-misc/sipcalc _FORTIFY_SOURCE indicates presence of overflow
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Krzysztof Pawlik (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: fortify-source
  Show dependency tree
 
Reported: 2010-09-18 12:02 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-11-11 12:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (sipcalc-1.1.4:20100917-152611.log,11.46 KB, text/plain)
2010-09-18 12:02 UTC, Diego Elio Pettenò (RETIRED)
Details
Patch to sipcalc-1.1.4.ebuild to fix reported overflow (and one other warning) (sipcalc-1.1.4.ebuild.patch,1.01 KB, patch)
2010-11-11 03:45 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-18 12:02:13 UTC
You're receiving this bug because the package in Summary has produced _FORTIFY_SOURCE related warnings indicating the presence of a sure overflow in a static buffer.

Even though this is not always an indication of a security problem it might even be. So please check this out ASAP.

By the way, _FORTIFY_SOURCE is disabled when you disable optimisation, so don't try finding out the cause using -O0.

Thanks,
Your friendly neighborhood tinderboxer
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-18 12:02:24 UTC
Created attachment 247813 [details]
Build log
Comment 2 Kevin Pyle 2010-11-11 03:45:08 UTC
Created attachment 253949 [details, diff]
Patch to sipcalc-1.1.4.ebuild to fix reported overflow (and one other warning)

This patch adds two sed statements.  The first fixes a format string warning.  The second adjusts the offending snprintf statements to use sizeof() to compute the length, which fixes the _FORTIFY_SOURCE warning.
Comment 3 Krzysztof Pawlik (RETIRED) gentoo-dev 2010-11-11 12:50:03 UTC
Version 1.1.5 which is in the tree doesn't suffer from this issue. Thank you Kevin for your contribution.