Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 337108 - dev-util/elfkickers does not respect LDFLAGS
Summary: dev-util/elfkickers does not respect LDFLAGS
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Anthony Basile
Depends on:
Blocks: ldflags
  Show dependency tree
Reported: 2010-09-13 17:41 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-11-02 18:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Build log (elfkickers-2.0a-r4:20100913-163622.log,12.12 KB, text/plain)
2010-09-13 17:42 UTC, Diego Elio Pettenò (RETIRED)
Patch to respect LDFLAGS (elfkickers-2.0a-respect-ldflags.patch,1.62 KB, text/plain)
2010-09-14 12:20 UTC, Anthony Basile
Consolidated patch (elfkickers-2.0a-r5.patch,33.11 KB, patch)
2010-10-24 15:25 UTC, Anthony Basile
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-13 17:41:51 UTC
See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-13 17:42:02 UTC
Created attachment 247155 [details]
Build log
Comment 2 solar (RETIRED) gentoo-dev 2010-09-14 01:19:49 UTC
Feel free to provide a patch and or patch it yourself.
Comment 3 Anthony Basile gentoo-dev 2010-09-14 11:30:36 UTC
(In reply to comment #2)
> Feel free to provide a patch and or patch it yourself.

I believe all that is required is to modify the line in all: in the top level Makefile to include LDFLAGS, like so:

for d in $(SUBDIRS); do cd $$d ; CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" CC=$(CC) $(MAKE) ; cd - ; done

and to similarly modify the makefile in subdirs elfls rebind  sstrip.  The elftoc subdir Makefile already respects LDFLAGS from the top level as written, and the tiny subdir is all asm.

I'm testing a patch I've got ready.  I'll upload it when I'm convinced it address the issue and doesn't cause regression.
Comment 4 Anthony Basile gentoo-dev 2010-09-14 12:20:04 UTC
Created attachment 247243 [details]
Patch to respect LDFLAGS

The ebuild is on my overlay if you want to see it.  It just adds a line

   epatch "${FILESDIR}"/elfkickers-2.0a-respect-ldflags.patch

to src_unpack().
Comment 5 Anthony Basile gentoo-dev 2010-10-24 15:25:20 UTC
Created attachment 251805 [details, diff]
Consolidated patch

I consolidated my earlier patch to respect LDFLAGS with the main patch, elfkickers-2.0a-r2.patch, and I also cleaned up some of the type mismatch warnings in printfs.

If anyone wants to review this, its also on my dev overlay along with the ebuild.  I'll put it on the tree in about a week.
Comment 6 Anthony Basile gentoo-dev 2010-11-02 18:22:21 UTC
Committed to the tree.  Please test.