335654 – sys-apps/shadow-4.1.2.2 counts failed logins wrongly

Bug 335654 - sys-apps/shadow-4.1.2.2 counts failed logins wrongly

Summary: sys-apps/shadow-4.1.2.2 counts failed logins wrongly

Status:	RESOLVED DUPLICATE of bug 200455

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Core system (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-09-02 07:49 UTC by C W Rose
Modified:	2010-09-06 20:05 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch to shadow/login.c to correct login error count (shadow.diff,447 bytes, patch) 2010-09-02 07:51 UTC, C W Rose	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description C W Rose 2010-09-02 07:49:19 UTC

If LOGIN_RETRIES is set to 3 in /etc/login/defs shadow fails on the
third attempt at login, whether the password is correct or not.  (This
has been the case in all recent versions of shadow, AFAIK.)

The situation is confused by the hardwired UNIX_MAX_RETRIES in the
Linux-PAM package, pam_unix/support,c, but the attatched patch does
actually fix the problem; it isn't caused by PAM.


Reproducible: Always

Steps to Reproduce:
1.  Try to log in twice with a bad password
2.  Try to log in with the correct password
3.  Fail

Actual Results:  
Failure with an error message from shadow/login.c

Expected Results:  
Success

Comment 1 C W Rose 2010-09-02 07:51:46 UTC

Created attachment 245727 [details, diff]
Patch to shadow/login.c to correct login error count

Patch for bug

Comment 2 SpanKY gentoo-dev

2010-09-06 20:05:17 UTC

dont file bugs about old packages.  no one cares.

*** This bug has been marked as a duplicate of bug 200455 ***