Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 334731 - net-dialup/ppp-2.4.5 - if_pppox.h:75: error: field ‘pppol2tpv3’ has incomplete type
Summary: net-dialup/ppp-2.4.5 - if_pppox.h:75: error: field ‘pppol2tpv3’ has incomplet...
Status: RESOLVED DUPLICATE of bug 334047
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Alin Năstac (RETIRED)
URL: https://bugzilla.redhat.com/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-27 06:01 UTC by :Lorenco Trichardt
Modified: 2010-08-29 22:08 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pyrodydno information (pyrodyno.txt,20.21 KB, text/plain)
2010-08-29 20:18 UTC, Guy
Details
pyrotekk information (pyrotekk.text,17.85 KB, text/plain)
2010-08-29 20:20 UTC, Guy
Details
slizard information (slizard.text,20.02 KB, text/plain)
2010-08-29 20:23 UTC, Guy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description :Lorenco Trichardt 2010-08-27 06:01:10 UTC
ppp failed with "if_pppox.h:75: error: field ‘pppol2tpv3’ has incomplete type"

Reproducible: Always

Steps to Reproduce:
emerge ppp with ~x86 flag
Actual Results:  
Build fails

Expected Results:  
Fix attached 

--- ppp-2.4.5/include/linux/if_pppol2tp.h       2009-11-16 22:26:07.000000000 +0000
+++ ppp-2.4.5/include/linux/if_pppol2tp.h       2010-07-16 22:35:22.000000000 +0100
@@ -32,6 +32,20 @@
        __u16 d_tunnel, d_session;      /* For sending outgoing packets */
 };
 
+/* The L2TPv3 protocol changes tunnel and session ids from 16 to 32
+ * bits. So we need a different sockaddr structure.
+ */
+struct pppol2tpv3_addr {
+       pid_t   pid;                    /* pid that owns the fd.
+                                        * 0 => current */
+       int     fd;                     /* FD of UDP or IP socket to use */
+
+       struct sockaddr_in addr;        /* IP address and port to send to */
+
+       __u32 s_tunnel, s_session;      /* For matching incoming packets */
+       __u32 d_tunnel, d_session;      /* For sending outgoing packets */
+};
+
 /* Socket options:
  * DEBUG       - bitmask of debug message categories
  * SENDSEQ     - 0 => don't send packets with sequence numbers
Comment 1 :Lorenco Trichardt 2010-08-27 06:03:26 UTC
More information:

if_pppox.h is included in the ppp package and need the patch
Could be that we also need this in the kernel ?
Comment 3 Denis Kaganovich 2010-08-28 15:31:55 UTC
Sorry, don't need to post. Crazy ;)
Comment 4 Guy 2010-08-29 19:31:09 UTC
For this bug and for bug #334397, I don't believe the described problems are correct. Rationale:

I have 3 nearly identical systems. Each system consists of AMD64 level processors, ATI radeon graphics chips and at least two gigs of memory. Two of the systems were "cloned" using minimal "stage4" saves from the original system about 2 months ago. Aside from some kernel setting variations to account for mobo chipset differences, these three systems really are virtually identical.

I recently upgraded "emerge --sync && emerge -uND world" two of these systems about 2 weeks ago (but no earlier than August 22) and both systems had no problem running ppp-2.4.5 and ntfs3g-2010.8.8 to completion.

About a week later, I followed up and upgraded the third system (also using "emerge --sync && emerge -uND world"). Both the ppp and ntfs3g upgrades failed as described in their respective bugzilla entries.

As it happens, I also re-upgraded the other two systems at the same time considering that there wouldn't be very many packages updated and also because I wanted the latest kernel updates. "emerge =ppp-2.4.5 =ntfs3g-2010.8.8" no longer run to completion on these two systems and fail in exactly the same way.

I thought that perhaps the upgrade of portage from portage-2.2_rc67 to portage-2.2_r69 might possibly have been the cause and therefore downgraded portage back to 2.2_rc67. The ppp and ntfs3g emerges still fail on all three systems.

I also tried upgrading portage to the latest version 2.2_rc72 and no still no joy. I don't know enough to feel comfortable downgrading python-2.6* and I also don't know enough to figure out which other packages I might consider downgrading for testing.

I'm putting together and attachment consisting of the "emerge --info" results for all three systems plus some other information I feel will show what I've mentioned here. I'll post it shortly.
Comment 5 Guy 2010-08-29 20:18:23 UTC
Created attachment 245267 [details]
pyrodydno information

For the computer systems named "pyrodyno", this file contains the results of:

emerge --info
emerge --depclean -p
emerge -pv ppp ntfs3g
revdep-rebuild -i -p
emerge ppp
Comment 6 Guy 2010-08-29 20:20:50 UTC
Created attachment 245268 [details]
pyrotekk information

For the computer systems named "pyrotekk", this file contains the results of:

emerge --info
emerge --depclean -p
emerge -pv ppp ntfs3g
revdep-rebuild -i -p
emerge ppp
Comment 7 Guy 2010-08-29 20:23:02 UTC
Created attachment 245269 [details]
slizard information

For the computer systems named "slizard", this file contains the results of:

emerge --info
emerge --depclean -p
emerge -pv ppp ntfs3g
emerge ppp

(oops - forgot to include "revdep-rebuild -i -p")
Comment 8 Guy 2010-08-29 20:25:26 UTC
I will be testing with some prior versions of the kernel. I want to check if the problem here and possibly with ntfs3g may be caused by an issue introduced in a kernel revision.

I'm currently running vanilla-sources-2.6.35.4 on all three systems.
Comment 9 Guy 2010-08-29 20:52:33 UTC
I did the following:

cd /usr/src
rm linux
ln -s linux-2.6.34.2/ linux
reboot

Since I have multiple kernels avaiable through my grub menu, I rebooted to vanilla-sources-2.6.34.2.

emerge ppp
emerge ntfs3g

The emerge of ppp-2.4.5 failed.
The emerge of ntfs3g-2010.8.8 went through to completion.

I'm going to test further by downgrading linux-headers and seeing if ppp will compile with that instead.
Comment 10 Guy 2010-08-29 21:10:49 UTC
You can execute the following:

emerge =linux-headers-2.6.34 && emerge ppp && emerge linux-headers

I don't know if ppp will work afterwords so I don't know if this is a valid workaround. Use at your own risk.
Comment 11 Guy 2010-08-29 21:33:46 UTC
See also bug #334047.

This bug should be closed in favor of 334047.
Comment 12 SpanKY gentoo-dev 2010-08-29 22:08:53 UTC
please search when filing bugs

*** This bug has been marked as a duplicate of bug 334047 ***