334465 – media-sound/bpmdetect does not respect LDFLAGS

Bug 334465 - media-sound/bpmdetect does not respect LDFLAGS

Summary: media-sound/bpmdetect does not respect LDFLAGS

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High QA (vote)
Assignee:	Gentoo Sound Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	ldflags
	Show dependency tree

Reported:	2010-08-25 15:56 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2016-01-27 18:45 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Build log (bpmdetect-0.6.1:20100825-151533.log,7.09 KB, text/plain) 2010-08-25 15:56 UTC, Diego Elio Pettenò (RETIRED)	Details
bpmdetect-0.6.1.ebuild-ldflags.patch (bpmdetect-0.6.1.ebuild-ldflags.patch,835 bytes, patch) 2010-11-12 14:01 UTC, Gavin Pryke	Details \| Diff
bpmdetect-0.6.1-SConscript.patch (bpmdetect-0.6.1-SConscript.patch,1.66 KB, patch) 2010-11-12 14:03 UTC, Gavin Pryke	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-25 15:56:15 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-25 15:56:25 UTC

Created attachment 244571 [details]
Build log

Comment 2 Gavin Pryke 2010-11-12 14:01:19 UTC

Attaching patches for bpmdetect-0.6.1 ebuild and SConscript. Thanks.

Comment 3 Gavin Pryke 2010-11-12 14:01:52 UTC

Created attachment 254085 [details, diff]
bpmdetect-0.6.1.ebuild-ldflags.patch

Comment 4 Gavin Pryke 2010-11-12 14:03:44 UTC

Created attachment 254087 [details, diff]
bpmdetect-0.6.1-SConscript.patch

Comment 5 Christian Strahl 2016-01-16 14:36:15 UTC

Please add the patches to the tree.

Comment 6 David Seifert gentoo-dev

2016-01-27 18:45:31 UTC

Compile line:

x86_64-pc-linux-gnu-g++ -o build/moc_dlgtestbpm.o -c -march=native -mtune=native -O2 -pipe -frecord-gcc-switches -fdiagnostics-color=always -Wformat -Werror=format-security -DQT_GUI_LIB -DNDEBUG -DNO_DEBUG -DHAVE_TAGLIB -DQT_SHARED -I/usr/include/taglib -Ibuild -Isrc -I. -Iincludes -I/usr/lib64/include -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtCore build/moc_dlgtestbpm.cc

Link line:

x86_64-pc-linux-gnu-g++ -o build/bpmdetect -Wl,--as-needed -Wl,-O1 -Wl,--hash-style=gnu -Wl,--sort-common -Wl,--no-undefined build/progressbar.o build/qdroplistview.o build/dlgbpmdetect.o build/dlgtestbpm.o build/main.o build/BPMDetect.o build/PeakFinder.o build/FIFOSampleBuffer.o build/track.o build/trackproxy.o build/trackfmod.o build/moc_progressbar.o build/moc_qdroplistview.o build/moc_dlgbpmdetect.o build/moc_dlgtestbpm.o -L/usr/lib -Lbuild -Lsrc -Llibs -L/opt/fmodex/api/lib -L/usr/lib64/lib -L/usr/lib64/qt4 -ltag -lid3 -lfmodex -lz -lQtGui -lQtCore

seems alright to me now. Thanks Gavin for the patch.

commit cfb62d0d06d25269c935b7029a1ca656ceecf86f
Author: David Seifert <soap@gentoo.org>
Date:   Wed Jan 27 19:42:56 2016 +0100

    media-sound/bpmdetect: Add patch to respect user flags
    
    Gentoo-Bug: 334465
    * EAPI=6
    * Added patch by Gavin Pryke to respect all user flags
    * Fixed QA issues caused by non-compliant .desktop file
    * Fixed QA issues caused by wrong printf() handling