Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 333093 - TuxOnIce kernel patch available for 2.6.35 kernel
Summary: TuxOnIce kernel patch available for 2.6.35 kernel
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Krzysztof Pawlik (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-16 23:35 UTC by Jesse Adelman
Modified: 2010-08-20 09:34 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Adelman 2010-08-16 23:35:39 UTC
News on http://www.tuxonice.net/ :

"15 August 2010: Patch for 2.6.35

A patch for the 2.6.35 kernel is now available. Humble apologies for the delay."

I know gentoo-tuxonice is "lightly supported", so I don't expect a rush on this. ;) But thanks in advance.
Comment 1 Dane Smith (RETIRED) gentoo-dev 2010-08-17 00:12:10 UTC
Assigning to maintainer and CC'ing herds.
Comment 2 Krzysztof Pawlik (RETIRED) gentoo-dev 2010-08-19 13:46:57 UTC
This is a "snapshot version", so no official version yet :| Also it fails to apply for me - hunk #2 fails for include/linux/fs.h:

patching file include/linux/fs.h
Hunk #2 FAILED at 210.
Hunk #3 succeeded at 236 (offset -1 lines).
Hunk #4 succeeded at 385 (offset -1 lines).
Hunk #5 succeeded at 1399 (offset -1 lines).
Hunk #6 succeeded at 1974 (offset -1 lines).
1 out of 6 hunks FAILED -- saving rejects to file include/linux/fs.h.rej

fs.h.rej:
--- include/linux/fs.h
+++ include/linux/fs.h
@@ -210,6 +211,7 @@
 #define MS_KERNMOUNT   (1<<22) /* this is a kern_mount call */
 #define MS_I_VERSION   (1<<23) /* Update inode I_version field */
 #define MS_STRICTATIME (1<<24) /* Always perform atime updates */
+#define MS_FROZEN      (1<<25) /* Frozen by freeze_filesystems() */
 #define MS_BORN                (1<<29)
 #define MS_ACTIVE      (1<<30)
 #define MS_NOUSER      (1<<31)

(the hunk fails because there's no MS_BORN in current fs.h).
Comment 3 djkrysak 2010-08-20 01:14:03 UTC
It looks like the Tuxonice patch was made with the 2.6.35.2 kernel in mind.  Seems that MS_BORN wasn't added until then.

Genpatches has a version 3 (http://sourcestest.gentoo.org/cgi-bin/viewvc.cgi/linux-patches/genpatches-2.6/tags/2.6.35-3/) which incldues the patch for 2.6.35.2.  Using version 3 lets the Tuxonice apply and seems to be working on my machine (suspended and resumed just fine).

Should I attach the entire ebuild or just make a patch from the 2.6.34 ebuild I used?
Comment 4 Krzysztof Pawlik (RETIRED) gentoo-dev 2010-08-20 09:17:29 UTC
2.6.35-3 is not used yet in gentoo-sources, we (as kernel team) are waiting for 2.6.35.3 patch to include it in 2.6.35-4 and that will be used (check http://archives.gentoo.org/gentoo-kernel/msg_3eb1198b265fc3d830979b296e921c02.xml).

I'll add 2.6.35 with TOI snapshot and 2.6.35-3 to the tree and when -4 comes out it will replace the one with -3.
Comment 5 Krzysztof Pawlik (RETIRED) gentoo-dev 2010-08-20 09:34:50 UTC
tuxonice-sources-2.6.35 (which includes genpatches-3 and TOI 20100815) added to the tree.