332479 – app-arch/par does not respect LDFLAGS

Bug 332479 - app-arch/par does not respect LDFLAGS

Summary: app-arch/par does not respect LDFLAGS

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High QA (vote)
Assignee:	Sven Wegener

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	ldflags
	Show dependency tree

Reported:	2010-08-12 16:20 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2012-11-25 15:32 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Build log (par-1.1:20100812-114017.log,1.67 KB, text/plain) 2010-08-12 16:20 UTC, Diego Elio Pettenò (RETIRED)	Details
Patch to par-1.1.ebuild to add a sed to fix upstream Makefile (par-1.1.ebuild.patch,657 bytes, patch) 2010-08-14 04:21 UTC, Kevin Pyle	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-12 16:20:22 UTC

See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-08-12 16:20:34 UTC

Created attachment 242619 [details]
Build log

Comment 2 Kevin Pyle 2010-08-14 04:21:30 UTC

Created attachment 242887 [details, diff]
Patch to par-1.1.ebuild to add a sed to fix upstream Makefile

The upstream Makefile uses an explicit rule to build par:

    $(CC) -o $@ $^

This rule does not include $(LDFLAGS), so the user's LDFLAGS are silently ignored.  The attached patch changes the CC to LINK.o, which is a GNU make built in variable defined as:

LINK.o = $(CC) $(LDFLAGS) $(TARGET_ARCH)

With the patch applied, I see my LDFLAGS applied to par.

Comment 3 Sven Wegener gentoo-dev

2012-11-25 15:32:11 UTC

Thanks, commited.