Can't find anyone on IRC, can I commit this? Index: whois-5.0.6.ebuild =================================================================== RCS file: /var/cvsroot/gentoo-x86/net-misc/whois/whois-5.0.6.ebuild,v retrieving revision 1.1 diff -u -r1.1 whois-5.0.6.ebuild --- whois-5.0.6.ebuild 24 Jul 2010 05:57:32 -0000 1.1 +++ whois-5.0.6.ebuild 28 Jul 2010 14:46:14 -0000 @@ -2,6 +2,7 @@ # Distributed under the terms of the GNU General Public License v2 # $Header: /var/cvsroot/gentoo-x86/net-misc/whois/whois-5.0.6.ebuild,v 1.1 2010/07/24 05:57:32 vapier Exp $ +EAPI=3 inherit eutils toolchain-funcs MY_P=${P/-/_} @@ -19,9 +20,7 @@ DEPEND="${RDEPEND} >=dev-lang/perl-5" -src_unpack() { - unpack ${A} - cd "${S}" +src_prepare() { epatch "${FILESDIR}"/${PN}-4.7.2-config-file.patch if use nls ; then @@ -37,13 +36,13 @@ } src_install() { - emake BASEDIR="${D}" prefix=/usr install || die + emake BASEDIR="${ED}" prefix=/usr install || die insinto /etc doins whois.conf dodoc README debian/changelog if [[ ${USERLAND} != "GNU" ]]; then - mv "${D}"/usr/share/man/man1/{whois,mdwhois}.1 - mv "${D}"/usr/bin/{whois,mdwhois} + mv "${ED}"/usr/share/man/man1/{whois,mdwhois}.1 + mv "${ED}"/usr/bin/{whois,mdwhois} fi }
If it works, should be fine.. wouldn't it need a dummy src_configure() { :; } though?
(In reply to comment #1) > If it works, should be fine.. wouldn't it need a dummy src_configure() { :; } > though? > Well, you are correct that src_confgiure() will be ran here. But that calls econf and econf checks for existance of $ECONF_SOURCE/configure (which doesn't exist in this package. So, I feel it is a style choice. Do you care if I add a dummy or not? <snip> >>> Source prepared. >>> Configuring source in /var/tmp/portage/net-misc/whois-5.0.6/work/whois-5.0.6 ... >>> Source configured. <snip>
TBH I'm always partial to add dummy when we expect a function to be no-op, had bad experience with automagic defaults changing.
(In reply to comment #3) > TBH I'm always partial to add dummy when we expect a function to be no-op, had > bad experience with automagic defaults changing. > OK, committed comment #0 with dummy src_configure. thx.
