327619 – [QA] dev-java/jss-4.3 Files built without respecting LDFLAGS have been detected

Bug 327619 - [QA] dev-java/jss-4.3 Files built without respecting LDFLAGS have been detected

Summary: [QA] dev-java/jss-4.3 Files built without respecting LDFLAGS have been detected

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Java team

URL:	https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:	ldflags
	Show dependency tree

Reported:	2010-07-09 13:41 UTC by Andreis Vinogradovs ( slepnoga )
Modified:	2010-08-09 21:00 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
adding epatch (jss-4.3.diff,219 bytes, patch) 2010-07-28 17:57 UTC, Kacper Kowalik (Xarthisius) (RETIRED)	Details \| Diff
respecting LDFLAGS (jss-4.3-ldflags.patch,350 bytes, patch) 2010-07-28 17:57 UTC, Kacper Kowalik (Xarthisius) (RETIRED)	Details \| Diff
jss-4.3-ldflags.patch (jss-4.3-ldflags.patch,270 bytes, text/plain) 2010-07-31 20:19 UTC, Andreis Vinogradovs ( slepnoga )	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreis Vinogradovs ( slepnoga ) 2010-07-09 13:41:43 UTC

>>> Completed installing jss-4.3 into /var/tmp/portage/dev-java/jss-4.3/image/

strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment
   usr/lib64/jss-3.4/libjss4.so

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/lib64/jss-3.4/libjss4.so

>>> Done.

Comment 1 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-07-28 17:57:25 UTC

Created attachment 240485 [details, diff]
adding epatch

Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-07-28 17:57:41 UTC

Created attachment 240487 [details, diff]
respecting LDFLAGS

Comment 3 Andreis Vinogradovs ( slepnoga ) 2010-07-31 19:24:49 UTC

(In reply to comment #2)
> Created an attachment (id=240487) [details]
> respecting LDFLAGS
> 

Patch fail .
Please, see for ${S} defenition in ebuild.
Base dir for diff creation - S=${WORKDIR}/mozilla

Comment 4 Andreis Vinogradovs ( slepnoga ) 2010-07-31 20:19:13 UTC

Created attachment 240877 [details]
jss-4.3-ldflags.patch

Comment 5 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-08-01 19:54:42 UTC

(In reply to comment #3)
> Patch fail .
Have you tried it?
> Please, see for ${S} defenition in ebuild.
> Base dir for diff creation - S=${WORKDIR}/mozilla
That's totally irrelevant as epatch tries to patch from -p0 till -p5...
Best regards,
Kacper Kowalik

Comment 6 Petteri Räty (RETIRED) gentoo-dev

2010-08-01 20:40:37 UTC

(In reply to comment #2)
> Created an attachment (id=240487) [details]
> respecting LDFLAGS
> 

Feel free to apply after you have reported the patch to upstream. Please add a link to the upstream report to the ebuild above epatch (and in the patch file itself).

Comment 7 Andreis Vinogradovs ( slepnoga ) 2010-08-01 21:39:25 UTC

(In reply to comment #5)
> (In reply to comment #3)
> > Patch fail .
> Have you tried it?
> > Please, see for ${S} defenition in ebuild.
> > Base dir for diff creation - S=${WORKDIR}/mozilla
> That's totally irrelevant as epatch tries to patch from -p0 till -p5...
> Best regards,
> Kacper Kowalik
> 

Yes :)
Plz, see http://code.google.com/p/slepnoga/source/browse/#hg/portage/dev-java/jss
Also, 4.2.5 are need patch

Comment 8 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2010-08-04 09:12:33 UTC

+  04 Aug 2010; Kacper Kowalik <xarthisius@gentoo.org> jss-4.3.ebuild,
+  +files/jss-4.3-ldflags.patch:
+  Respect LDFLAGS wrt bug 327619. Thanks to Andreis Vinogradovs (slepnoga)
+  <spamslepnoga@inbox.ru> for the report.
+