Bug 326923 – revdep-rebuild: incorrect exit status for masked packages

• Status: RESOLVED FIXED
• Product: Portage Development

[Description James Broadhead 2010-07-04 20:44:12 UTC]

revdep-rebuild is returning 0 for a failed rebuild, where a package that is only available on ~arch is required to be rebuilt, and there is no candidate. 


revdep-rebuild manpage: 
"revdep-rebuild returns a zero exit status  if it  and  emerge  succeeds, and a nonzero exit status otherwise."

Versions Tested: 
app-portage/gentoolkit-0.2.4.6.1-r1
app-portage/gentoolkit-0.3.0_rc10-r1

emerge --info and revdep-rebuild temp files attached. 

Reproducible: Always

[Comment 1 James Broadhead 2010-07-04 20:44:25 UTC]

Created attachment 237487 [details]
emerge --info

[Comment 2 James Broadhead 2010-07-04 20:45:57 UTC]

Created attachment 237489 [details]
revdep-rebuild temp files

[Comment 3 James Broadhead 2010-07-04 20:46:13 UTC]

Created attachment 237491 [details]
revdep-rebuild files

[Comment 4 James Broadhead 2010-07-04 20:48:03 UTC]

revdep-rebuild --library libpng12.so.0 &>> file ; echo $? &>> file

file attached as console-output

[Comment 5 James Broadhead 2010-07-04 20:48:16 UTC]

Created attachment 237493 [details]
console output

[Comment 6 James Broadhead 2010-07-04 20:51:50 UTC]

Just for completeness : 

>> emerge -1 php-gtk ; echo $?
Calculating dependencies... done!

!!! All ebuilds that could satisfy "dev-php5/php-gtk" have been masked.
!!! One of the following masked packages is required to complete your request:
- dev-php5/php-gtk-2.0.1-r3 (masked by: ~x86 keyword)
- dev-php5/php-gtk-2.0.1-r2 (masked by: ~x86 keyword)


For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.

1

[Comment 7 Max Hacking 2010-08-05 02:26:16 UTC]

The fix is trivial....but it is late so I can't be bothered to make a patch.

For the interested find the bit which looks a bit like this and make it look exactly like this.  :-)

##
# Finish up
cleanup() {
	EMERGE_STATUS=$(<"$STATUS_FILE")
	if (( $EMERGE_STATUS != 0 )); then
		ewarn
		ewarn "$APP_NAME failed to emerge all packages."



Suffice to say the original does not have the variable assignment.  :-(

[Comment 8 James Broadhead 2010-08-05 03:56:56 UTC]

Created attachment 241463 [details, diff]
patch as described

Thanks for doing the legwork :)

[Comment 9 [e-mail] 2010-11-03 15:41:45 UTC]

*** Bug 323185 has been marked as a duplicate of this bug. ***

[Comment 10 James Broadhead 2010-11-03 15:45:44 UTC]

(In reply to comment #8)
> Created an attachment (id=241463) [details]
> patch as described
> 
> Thanks for doing the legwork :)
> 

Can we have this merged at some point ?

[Comment 11 James Broadhead 2011-04-24 19:57:03 UTC]

Patched version now available in my overlay: 
jamesbroadhead.googlecode.com/hg/portage-overlay

[Comment 12 Paul Varner (RETIRED) 2012-02-16 17:49:48 UTC]

This is fixed in the following commit:

http://git.overlays.gentoo.org/gitweb/?p=proj/gentoolkit.git;a=commitdiff;h=3e51df74595c535656ef9f38bf7a577a4f64d0f5;hp=d1ee16c4194e7a94c91924d62332363d06e64aae

[Comment 13 Paul Varner (RETIRED) 2012-02-29 15:42:02 UTC]

Released in gentoolkit-0.3.0.5