Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 324399 - dev-util/ghh: Verify and potentially improve Python-related code
Summary: dev-util/ghh: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-06-16 20:40 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2011-11-26 17:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (ghh.patch,1.17 KB, patch)
2011-11-14 00:06 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (ghh.patch,1.22 KB, patch)
2011-11-24 23:22 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (ghh.patch,1.17 KB, patch)
2011-11-25 22:33 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (ghh.patch,1.22 KB, patch)
2011-11-26 10:57 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-16 20:40:46 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 David Abbott (RETIRED) gentoo-dev 2010-06-18 22:16:42 UTC
From the most recent entry in the change log from jfrichard (author)
November 19, 2009

This project is not actively maintained since early 2008.  It has thus *NOT*
been tested on modern distributions and recent Git versions.  It might work,
it might not work.
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2011-11-14 00:06:45 UTC
Created attachment 292449 [details, diff]
ebuild patch

there is a mixup between git.eclass and git-2.eclass.
After adding one function, git_src_prepare(), from git to git-2, it was still crying out for 

* QA Notice: command not found:
 * 
 * 	/mnt/gen2/tmpdir/portage/dev-util/ghh-9999/temp/environment: line 3101: git_apply_patches: command not found
 * 	/mnt/gen2/tmpdir/portage/dev-util/ghh-9999/temp/environment: line 3102: git_bootstrap: command not found

Patch for python versioning.
Comment 3 Arfrever Frehtes Taifersar Arahesis 2011-11-23 21:15:20 UTC
(In reply to comment #2)

This package should depend on dev-python/pygtk:2.
This package supports only Python 2.
Don't change DESTDIR="${D}" to DESTDIR="${ED}".
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2011-11-24 23:22:56 UTC
Created attachment 293675 [details, diff]
revised ebuild patch
Comment 5 Arfrever Frehtes Taifersar Arahesis 2011-11-25 21:28:24 UTC
(In reply to comment #4)

PYTHON_DEPEND="2:2.6"
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2011-11-25 22:33:55 UTC
Created attachment 293771 [details, diff]
revised ebuild patch

done
Comment 7 Arfrever Frehtes Taifersar Arahesis 2011-11-25 23:48:11 UTC
(In reply to comment #6)

You also introduced some wrong changes.
Start with patch from comment #4 and apply only suggestion from comment #5.
Comment 8 Ian Delaney (RETIRED) gentoo-dev 2011-11-26 10:57:32 UTC
Created attachment 293811 [details, diff]
revised ebuild patch
Comment 9 Mike Gilbert gentoo-dev 2011-11-26 17:24:18 UTC
+  26 Nov 2011; Mike Gilbert <floppym@gentoo.org> ghh-9999.ebuild:
+  Python-related improvements by Ian Delaney. Bug 324399.