Bug 324371 – dev-util/bam: Verify and potentially improve Python-related code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-16 20:12:10 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Ian Delaney (RETIRED) 2011-11-13 10:40:35 UTC]

Created attachment 292385 [details]
ebuild patch

Tested, left at EAPI 2. all ok

[Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-14 17:59:08 UTC]

(In reply to comment #1)

This package needs Python 2, and only at build time. Don't set PYTHON_DEPEND.

If new syntax of PYTHON_DEPEND/PYTHON_BDEPEND was available in gentoo-x86, then PYTHON_BDEPEND="doc? ( <<2>> ) test? ( <<2>> )" should be used.

In the meantime, please use:
DEPEND="${RDEPEND}
	doc? ( =dev-lang/python-2* )
	test? ( =dev-lang/python-2* )"

Please use:
pkg_setup() {
	if use doc || use test; then
		python_set_active_version 2
		python_pkg_setup
	fi
}

[Comment 3 Ian Delaney (RETIRED) 2011-11-18 19:19:38 UTC]

Created attachment 293015 [details, diff]
revised ebuild patch

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-20 06:28:42 UTC]

(In reply to comment #3)

This patch is not for unmodified ebuilds.

[Comment 5 Ian Delaney (RETIRED) 2011-11-26 15:31:57 UTC]

Created attachment 293849 [details, diff]
revised ebuild patch

[Comment 6 Tupone Alfredo 2012-03-27 15:06:54 UTC]

Fixed in the new bumped version.