Bug 324369 – dev-util/aap: Verify and potentially improve Python-related code

• Status: RESOLVED OBSOLETE
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-16 20:11:11 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Ian Delaney (RETIRED) 2011-11-13 12:42:07 UTC]

Created attachment 292391 [details]
ebuild patch

tested all ok.  bumped to EAPI 3

[Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-14 18:16:52 UTC]

(In reply to comment #1)

This package needs Python 2.
Shebang in aap script should be fixed.
'python_mod_optimize /usr/share/aap' and 'python_mod_cleanup /usr/share/aap' should added.

[Comment 3 Ian Delaney (RETIRED) 2011-11-18 17:31:34 UTC]

Created attachment 292997 [details, diff]
revised ebuild patch

done

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-20 03:37:38 UTC]

(In reply to comment #3)

s/src_pkg_setup/pkg_setup/
Please read documentation of all ebuild phases.

${ED} should be quoted.

[Comment 5 Ian Delaney (RETIRED) 2011-11-21 13:46:03 UTC]

Created attachment 293311 [details, diff]
revised ebuild patch

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-23 17:45:31 UTC]

(In reply to comment #5)

Delete '>=dev-lang/python-1.5' from RDEPEND.

[Comment 7 Ian Delaney (RETIRED) 2011-11-24 22:01:27 UTC]

Created attachment 293659 [details, diff]
revised ebuild patch

[Comment 8 Arfrever Frehtes Taifersar Arahesis 2011-11-25 21:36:44 UTC]

(In reply to comment #7)

Set empty RDEPEND.
s/src_pkg_setup/pkg_setup/

[Comment 9 Ian Delaney (RETIRED) 2011-11-26 11:03:53 UTC]

Created attachment 293813 [details, diff]
revised ebuild patch

[Comment 10 Arfrever Frehtes Taifersar Arahesis 2011-11-27 18:14:34 UTC]

(In reply to comment #9)

This patch doesn't apply cleanly.

[Comment 11 Ian Delaney (RETIRED) 2011-11-27 19:58:53 UTC]

Created attachment 293975 [details, diff]
revised ebuild patch

[Comment 12 Arfrever Frehtes Taifersar Arahesis 2011-11-27 21:00:52 UTC]

(In reply to comment #11)

Compare this patch with patch from comment #9 and notice that calls to python_convert_shebangs(), python_mod_optimize() and python_mod_cleanup() incorrectly disappeared.

[Comment 13 Ian Delaney (RETIRED) 2011-11-27 21:37:39 UTC]

Created attachment 293985 [details, diff]
revised ebuild patch

[Comment 14 Arfrever Frehtes Taifersar Arahesis 2011-11-27 21:45:34 UTC]

(In reply to comment #13)

You shouldn't remove this line:
cp -R doc/* "${D}"/usr/share/doc/${PF}/html

[Comment 15 Ian Delaney (RETIRED) 2011-11-27 22:10:37 UTC]

Created attachment 293991 [details, diff]
removed the remove

done

[Comment 16 Pacho Ramos 2015-10-03 09:30:02 UTC]

This approach was changed by the -r1 python eclasses