321895 – dev-vcs/git-1.7.1[-iconv] segfaults with USE=-iconv

Bug 321895 - dev-vcs/git-1.7.1[-iconv] segfaults with USE=-iconv

Summary: dev-vcs/git-1.7.1[-iconv] segfaults with USE=-iconv

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Robin Johnson

URL:
Whiteboard:
Keywords:

Duplicates (1):	320871 (view as bug list)
Depends on:
Blocks:

Reported:	2010-05-28 20:09 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2010-09-25 17:38 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-05-28 20:09:35 UTC

I'll try to reduce this to the minimum:

flame@yamato netembryo % git cherry-pick fcea6009f36490ae9501c6b3269601fa0e5fc08a
zsh: segmentation fault (core dumped)  git cherry-pick fcea6009f36490ae9501c6b3269601fa0e5fc08a

[…]


Program received signal SIGSEGV, Segmentation fault.
0x0000000000464b78 in get_message (
    raw_message=0x7a4150 "tree 0c7bc2914aa8066e732fef98d4b03489d1217427\nparent 17c2a6656c6e0e55c51d8f26f1a08df29a678ffe\nauthor Diego Elio 'Flameeyes' Pettenò <flameeyes@gmail.com> 1274886428 +0200\ncommitter Diego Elio 'Flamee"..., out=0x7fffffffce60) at builtin/revert.c:121
121	in builtin/revert.c
(gdb) info locals
encoding = 0x51a74a "UTF-8"
p = 0x0
abbrev = 0x79f900 "fcea600"
eol = 0x0
q = 0x0
abbrev_len = 7
oneline_len = 8116136

[…]

in get_message():

        if ((out->reencoded_message = reencode_string(raw_message,
                                        git_commit_encoding, encoding)))
                out->message = out->reencoded_message;
[…]
        p = out->message;
        while (*p && (*p != '\n' || p[1] != '\n'))
                p++;


in utf8.h:

#ifndef NO_ICONV
char *reencode_string(const char *in, const char *out_encoding, const char *in_encoding);
#else
#define reencode_string(a,b,c) NULL
#endif

Comment 1 Robin Johnson archtester

2010-05-28 20:29:12 UTC

fixed in CVS, 1.7.1-r1

Comment 2 Fabian Groffen gentoo-dev

2010-05-29 08:25:19 UTC

*** Bug 320871 has been marked as a duplicate of this bug. ***

Comment 3 Gianluigi Tiesi 2010-09-25 17:38:54 UTC

please add iconv ebuild to deps on uclibc (maybe also freebsd)
because it's a separate package