Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 321665 - media-gfx/graphviz: Verify and potentially improve Python-related code
Summary: media-gfx/graphviz: Verify and potentially improve Python-related code
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-05-27 10:40 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2015-10-03 09:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-05-27 10:40:56 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-05-27 10:43:02 UTC
Additional problems:
- `configure` doesn't fail when --enable-python has been explicitly passed and
  Python has not been found.
- Parsing of Python version is incorrect and snapshots of Python are not found.
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-10 15:49:39 UTC
media-gfx/graphviz-2.26.3-r2 doesn't support Python 3, so I have fixed detection of Python 2. This package doesn't install any Python scripts.

The problems described in comment #1 still need to be fixed.
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-10 15:56:14 UTC
The following empty directories probably shouldn't be installed:
/usr/$(get_libdir)/graphviz/python23
/usr/$(get_libdir)/graphviz/python24
/usr/$(get_libdir)/graphviz/python25
/usr/$(get_libdir)/graphviz/python26

The same Python modules are installed in:
/usr/$(get_libdir)/graphviz/python
$(python_get_sitedir)

Maybe /usr/$(get_libdir)/graphviz/python could be removed.
Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-10 16:01:38 UTC
(In reply to comment #3)
> The same Python modules are installed in:
> /usr/$(get_libdir)/graphviz/python
> $(python_get_sitedir)

I hadn't noticed that modules in $(python_get_sitedir) are symlinks.