Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 320563 - >=sys-apps/parted-1.9.0 does not always inform kernel of partition changes
Summary: >=sys-apps/parted-1.9.0 does not always inform kernel of partition changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo LiveCD Package Maintainers
URL: http://gparted.sourceforge.net/news.php
Whiteboard:
Keywords:
Depends on:
Blocks: 316453
  Show dependency tree
 
Reported: 2010-05-19 14:22 UTC by Andreas Kinzler
Modified: 2010-06-03 23:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to add the 3 recommended changes (parted-2.2-020510.patch,12.42 KB, patch)
2010-05-19 14:23 UTC, Andreas Kinzler
Details | Diff
ebuild for parted 2.2 with important git patches from 2010/05/10 (parted-2.2_p20100510.ebuild,1.40 KB, text/plain)
2010-05-19 16:57 UTC, Andreas Kinzler
Details
extract of important git patches from 2010/05/10 (parted-2.2-git20100510.patch,38.50 KB, patch)
2010-05-19 16:58 UTC, Andreas Kinzler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kinzler 2010-05-19 14:22:15 UTC
From "http://gparted.sourceforge.net/news.php"

It appears that the Parted 1.9.0 through 2.2 releases have lost some capability that earlier releases (1.8.8 and earlier) possessed.

These newer Parted releases are unable to inform the kernel of partition changes if another partition is mounted, or if an active LVM partition is on the same device.
This latter case was reported in the following bug report:
Bug 608712 - GParted fails to edit/delete partitions if active LVM on same disk device

Fortunately, the parted git repository contains updates that restore this capability.

In light of this and potential problems with dmraid, Steven Shiau has kindly updated GParted Live 0.5.2-9 with the following three patches:

    * libparted: don't canonicalize /dev/mapper paths
    * libparted: reenable use of BLKPG ioctls
    * libparted: improve BLKPG error checking

The above three patches improve support for DMRAID, and permit editing unmounted partitions on devices that have at least one mounted partition and/or an active LVM partition.

We recommend the above three patches be applied to parted-2.2 if you are compiling your own copy of Parted or using libparted with GParted.


Reproducible: Always

Steps to Reproduce:
Comment 1 Andreas Kinzler 2010-05-19 14:23:37 UTC
Created attachment 232099 [details, diff]
patch to add the 3 recommended changes
Comment 2 Andreas Kinzler 2010-05-19 16:57:43 UTC
Created attachment 232117 [details]
ebuild for parted 2.2 with important git patches from 2010/05/10
Comment 3 Andreas Kinzler 2010-05-19 16:58:44 UTC
Created attachment 232119 [details, diff]
extract of important git patches from 2010/05/10
Comment 4 Andreas Kinzler 2010-05-19 17:00:36 UTC
(In reply to comment #1)

Patches from #1 still not sufficient. I had severe data loss with parted-2.2 from vanilla portage because of kernel partition table re-read problems.

So far all problems gone with git patch set 2010/05/10
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2010-05-20 13:55:38 UTC
Comment on attachment 232117 [details]
ebuild for parted 2.2 with important git patches from 2010/05/10

Please file a patch next time, not a complete ebuild.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2010-05-20 18:40:22 UTC
(In reply to comment #3)
> Created an attachment (id=232119) [details]
> extract of important git patches from 2010/05/10

Could you please clean up that patch a bit? I don't see why the version change is necessary if it's basically intended as a backport to the 2.2 code. The patch is also missing references to the relevant git changes and the various chunks have no one-to-one relation with the three patches that the [URL] references.

I'd like to get this problem solved as soon as possible, but I could also wait for 2.2.1 to be released.
Comment 7 Andreas Kinzler 2010-05-21 07:17:33 UTC
Let me clarify: patch #1 contains exactly the 3 recommended patches from the [URL]. This did not solve the problem. Next I decided I want to try the current git master. I created a patch (#3) containing the git master with ALL (approx. 30) patches that touch the tree branches "/libparted", "/include", "/parted" skipping any modifications on tests/docs. This did solve the problem. I made up the version "2.2.1" to give the user some visible indication that he is not using the faulty "2.2.0" version. If you do not like that feel free to drop the changes on "configure". All of my work is just an offer to the community. I'd like to see some testing on a fixed version (can be my version or any other patchset) and then have this into stable since vanilla portage 2.2.0 destroys peoples partitions.
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2010-06-03 23:54:46 UTC
2.3 is out now and should fix these issues. Thanks for reporting.