Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 318485 - [patch] net-misc/hylafax-6.0.3 - various QA issues
Summary: [patch] net-misc/hylafax-6.0.3 - various QA issues
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Steve Arnold
URL: http://bugs.hylafax.org/show_bug.cgi?...
Whiteboard:
Keywords:
Depends on:
Blocks: 361187
  Show dependency tree
 
Reported: 2010-05-04 18:39 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-02-26 17:50 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (hylafax-6.0.3:20100504-160206.log,18.25 KB, text/plain)
2010-05-04 18:39 UTC, Diego Elio Pettenò (RETIRED)
Details
Patch to hylafax-6.0.3.ebuild to fix gcc 4.5 compilation, and other problems (hylafax-6.0.3.ebuild.patch,1.66 KB, patch)
2010-08-29 23:53 UTC, Kevin Pyle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-05-04 18:39:11 UTC
Portage 2.1.8.3 (default/linux/x86/10.0, gcc-4.5.0-asneeded, glibc-2.11.1-r0, 2.6.33.3 i686)
=================================================================
System uname: Linux-2.6.33.3-i686-Quad-Core_AMD_Opteron-tm-_Processor_2350-with-gentoo-2.0.1
Timestamp of tree: Tue, 04 May 2010 11:30:01 +0000
app-shells/bash:     4.1_p5
dev-java/java-config: 2.1.11
dev-lang/python:     2.6.5-r2, 3.1.2-r3
dev-python/pycrypto: 2.1.0
dev-util/cmake:      2.8.1-r1
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.1-r1
sys-apps/sandbox:    2.2
sys-devel/autoconf:  2.13, 2.65
sys-devel/automake:  1.4_p6-r1, 1.5-r1, 1.6.3-r1, 1.7.9-r2, 1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1
sys-devel/gcc:       4.5.0
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6b
virtual/os-headers:  2.6.33
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb /var/lib/hsqldb /var/qmail/alias /var/qmail/control /var/yp/Makefile"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/cache/distfiles"
FEATURES="assume-digests distlocks fixpackages news parallel-fetch protect-owned sandbox sfperms split-log strict test test-fail-continue unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j14"
PKGDIR="/var/spool/portage/packages"
PORTAGE_COMPRESS=""
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/cache/portage/tree-tinderbox"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="acl berkdb bzip2 cli cracklib crypt cups cxx dri fortran gdbm gpm iconv ipv6 java5 java6 modules mudflap ncurses nls nostatic nptl nptlonly openmp pam pcre perl pppd python qt3support readline reflection ruby session spl ssl sysfs tcpd unicode vhosts x86 xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias auth_digest" ELIBC="glibc" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" RUBY_TARGETS="ruby18 jruby ruby19" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-05-04 18:39:34 UTC
Created attachment 230329 [details]
Build log
Comment 2 Kevin Pyle 2010-08-29 23:53:16 UTC
Created attachment 245282 [details, diff]
Patch to hylafax-6.0.3.ebuild to fix gcc 4.5 compilation, and other problems

Upstream considers this a gcc bug, because their configure script (not autotools-based, just named configure) runs a test that includes a missing header ("libc.h") along with some valid ones.  Earlier gcc versions print a warning on the missing header, but gcc 4.5 actually errors out.  This confuses their configure script into wrongly deciding that fchmod is not available, so they then define an incorrect prototype for it.  After removing that bogus include from the list of files to check, compilation runs through successfully.  There are some other issues, which also need to be fixed.

Fixed here:
- $LDFLAGS ignored for many files.  Upstream already claimed the symbol $LDFLAGS for something else, so I inserted references to $(USER_LDFLAGS) and added a USER_LDFLAGS="${LDFLAGS}" to emake.
- Gentoo attempt at setting compiler was ignored.  I dropped the old method and replaced it with appending the desired settings to config.site, which does cause a qualified name to be used.
- Delete reference to non-existent libc.h that caused upstream configure script to fail to detect fchmod.
- Moved a sed from src_configure to src_prepare, since src_prepare already existed.

Not addressed here:
- ebuild uses -j1 on the call to emake.
- rampant CFLAGS/CXXFLAGS confusion.  If I include -Wpointer-sign (a C only flag) in $CFLAGS, I get spammed with warnings from the hylafax build system passing my $CFLAGS to $CXX.
- libhylafax-6.0.so.3 is stripped before Portage gets to work on it.
Comment 3 Ryan Hill (RETIRED) gentoo-dev 2010-10-27 03:17:02 UTC
Thanks.  I'm cherry-picking the 4.5 fix for now.

QA - this ebuild needs some serious TLC
Comment 4 Kevin Pyle 2010-10-27 03:38:45 UTC
(In reply to comment #3)
> I'm cherry-picking the 4.5 fix for now.

Fair enough, but your choice of how to do the change strikes me as a bit odd.  There was an existing sed on configure that my patch extended, but you instead added a separate sed call, so configure is edited twice.  Also, your new sed lacks an ||die.  This is probably not a big deal since it occurs after the original sed with the ||die, but it seems like it would be simpler to make the removal of the libc.h include part of the existing sed, as I did in attachment #245282 [details, diff].
Comment 5 Ryan Hill (RETIRED) gentoo-dev 2010-10-27 04:26:49 UTC
That sed updated the tiff version check.  It's conceptually separate from this change.  While it might be simpler to stick a line in the existing sed now, I've found teasing out what does what a year or two later (after someone's added a few more expressions (not commenting them of course)) can be a bit of a pain.

I guess a die doesn't hurt, so added.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2012-02-26 17:50:15 UTC
Closing as WONTFIX because hylafax was removed from Portage. But adding 361187 to Blocks: -line since this bug should get fixed if introduced back to Portage.