Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 317545 - x11-libs/gtk+ unnecessary dependencies
Summary: x11-libs/gtk+ unnecessary dependencies
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-27 22:11 UTC by Patrick
Modified: 2010-04-29 12:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick 2010-04-27 22:11:05 UTC
gtk+-2.18.6 has dependencies in it that arent dependencies.
The x11-libs/libXrandr and x11-libs/libXcomposite are not required. I modified the ebuild to remove them, the package compiled, and gtk+ apps work just fine without them.

Granted, an app which wants either of those 2 wont have them, but then they should controlled via USE flags.

Reproducible: Always

Steps to Reproduce:
1. mkdir -p /usr/local/portage/x11-libs
2. cp -a /usr/portage/x11-libs/gtk+ /usr/local/portage/x11-libs
3. vi /usr/local/portage/x11-libs/gtk+/gtk+-2.18.6.ebuild (and remove deps)
4. ebuild /usr/local/portage/x11-libs/gtk+/gtk+-2.18.6.ebuild digest
5. emerge gtk+
Comment 1 Pacho Ramos gentoo-dev 2010-04-28 20:29:06 UTC
The are clearly listed as depends in configure.in file that you can read in, for example:
http://git.gnome.org/browse/gtk+/tree/configure.in
Comment 2 Patrick 2010-04-28 20:43:45 UTC
Where?
I see checks for Xrandr and Xcomposite, but I see them as optional. If they were required, you'd see a AC_MSG_ERROR call, but there isnt one. So not dependencies.
Comment 3 Patrick 2010-04-28 20:49:26 UTC
Heres some additional proof.
A box with the unmodified ebuild:
# ldd /usr/lib/libgtk-x11-2.0.so | grep -Ei "(Xrandr|Xcomposite)"
        libXrandr.so.2 => /usr/lib/libXrandr.so.2 (0x00007f284a613000)
        libXcomposite.so.1 => /usr/lib/libXcomposite.so.1 (0x00007f2849dde000)
#

The box I built without Xrandr and Xcomposite:
# ldd /usr/lib/libgtk-x11-2.0.so | grep -Ei "(Xrandr|Xcomposite)"
#
^^no output
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-04-29 12:46:45 UTC
If they are automagic, we have to decide whether to patch the build system or just force them as mandatory. Cfr. http://www.gentoo.org/proj/en/qa/automagic.xml

Feel free to ask upstream about those… fwiw Xinerama had a similar story (see my own bug #118744).