Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 317005 - x11-misc/denu: Verify and potentially improve Python-related code
Summary: x11-misc/denu: Verify and potentially improve Python-related code
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: No maintainer - Look at if you want to take care of it
Depends on:
Blocks: 308257
  Show dependency tree
Reported: 2010-04-24 18:43 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2011-11-26 17:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

denu-2.3.2.ebuild (denu-2.3.2.ebuild,666 bytes, text/plain)
2010-06-03 12:40 UTC, David Abbott
denu-2.3.2.ebuild (denu-2.3.2.ebuild,690 bytes, text/plain)
2010-06-03 12:47 UTC, David Abbott
ebuild patch (denu.patch,918 bytes, patch)
2011-11-25 15:09 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (denu.patch,914 bytes, patch)
2011-11-26 12:42 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-24 18:43:00 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
Comment 1 David Abbott gentoo-dev 2010-06-03 12:40:42 UTC
Created attachment 233963 [details]

Python script from 2005, only works with Python 2. Tested up to python 2.6.

QA Security Notice:
- /var/cache/denu/new_sysprgms.p will be a world writable file.
- This may or may not be a security problem, most of the time it is one.
- Please double check that denu-2.3.2 really needs a world writeable bit and file bugs accordingly.

Also this error with Python 3 as active;
denu --help
  File "/usr/bin/denu", line 363
    wm = string.replace(wm, '.p', '')
TabError: inconsistent use of tabs and spaces in indentation
Comment 2 David Abbott gentoo-dev 2010-06-03 12:47:43 UTC
Created attachment 233965 [details]

It will install with Python 3 set as active version, I forgot to add;
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-03 13:55:46 UTC
Comment on attachment 233965 [details]

It won't work.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2011-11-25 15:09:55 UTC
Created attachment 293715 [details, diff]
ebuild patch
Comment 5 Arfrever Frehtes Taifersar Arahesis 2011-11-25 23:28:45 UTC
(In reply to comment #4)

Comment 6 Ian Delaney (RETIRED) gentoo-dev 2011-11-26 12:42:26 UTC
Created attachment 293829 [details, diff]
revised ebuild patch
Comment 7 Mike Gilbert gentoo-dev 2011-11-26 17:15:52 UTC
+*denu-2.3.2-r1 (26 Nov 2011)
+  26 Nov 2011; Mike Gilbert <> +denu-2.3.2-r1.ebuild:
+  Python-related improvements by Ian Delaney. Bug 317005.