Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 316573 - Celestia 1.6.0 portability problem wrt char (un)signedness
Summary: Celestia 1.6.0 portability problem wrt char (un)signedness
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC Linux
: High normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-21 19:43 UTC by Alex Buell
Modified: 2010-08-12 02:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Screenshot #1 (1.png,163.01 KB, image/png)
2010-04-21 19:44 UTC, Alex Buell
Details
Screenshot #2 (2.png,108.56 KB, image/png)
2010-04-21 19:44 UTC, Alex Buell
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buell 2010-04-21 19:43:37 UTC
The variable(s) describing the vertical displacement of characters is of type
char and assumed to be signed. On systems where char is unsigned by default,
characters with a negative displacement are drawn 256 pixels too high. :)

Unfortunately, a quick look didn't reveal the offending variable(s), but
building with -fsigned-char fixes the problem.

This problem was fixed on x86 platforms, but notr fixed on ppc platforms - I'm running a iMac G3 600 w/ 2.6.32-r7

Reproducible: Always

Steps to Reproduce:
1.Start Celestia
2.Run Demo mode (press D)
3.Look for misplaced letters being placed all over the screen

This does not happens on x86, only on ppc. 


Expected Results:  
Should have perfectly rendered text with no misplaced text. See screenshots attached.
Comment 1 Alex Buell 2010-04-21 19:44:04 UTC
Created attachment 228657 [details]
Screenshot #1
Comment 2 Alex Buell 2010-04-21 19:44:43 UTC
Created attachment 228659 [details]
Screenshot #2
Comment 3 Sébastien Fabbro (RETIRED) gentoo-dev 2010-04-23 13:35:08 UTC
@ppc, could you confirm the fact by adding -fsigned-char to the CXXFLAGS fixes the problem?
Thanks.
Comment 4 Joe Jezak (RETIRED) gentoo-dev 2010-08-12 02:53:32 UTC
It does fix the problem. I've added the flag to ebuild. I also took a look at the code, but didn't see where it was. Perhaps it should be reported upstream?