Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315881 - net-voip/telepathy-butterfly: Verify and potentially improve Python-related code
Summary: net-voip/telepathy-butterfly: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal
Assignee: voip herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-18 02:54 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2011-02-07 19:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
telepathy-butterfly-0.5.1.ebuild.patch (telepathy-butterfly-0.5.1.ebuild.patch,370 bytes, patch)
2010-06-14 19:51 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-18 02:54:44 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-14 19:51:33 UTC
Created attachment 235313 [details, diff]
telepathy-butterfly-0.5.1.ebuild.patch

This patch only removes deprecation warnings.

I will commit this patch, if you don't object in 1 week.
Comment 2 Olivier Crete (RETIRED) gentoo-dev 2010-06-14 20:09:53 UTC
go for it
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-14 20:18:17 UTC
Comment on attachment 235313 [details, diff]
telepathy-butterfly-0.5.1.ebuild.patch

Committed.
Comment 4 Pacho Ramos gentoo-dev 2011-02-07 18:44:03 UTC
Should be fixed in telepathy-butterfly-0.5.15
Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-02-07 18:55:16 UTC
There are syntax errors with Python 3.

Please add:

pkg_postinst() {
	python_mod_optimize butterfly
}

pkg_postrm() {
	python_mod_cleanup butterfly
}
Comment 6 Pacho Ramos gentoo-dev 2011-02-07 19:04:25 UTC
Done, thanks a lot

(In reply to comment #5)
> There are syntax errors with Python 3.
> 

Wouldn't be possible to add some kind of test or warning for preventing errors like this? 
Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-02-07 19:13:43 UTC
You still need to update dependencies and restrict 3.* Python ABIs.
Calling python_mod_optimize() allows to detect syntax errors.
Comment 8 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-02-07 19:18:17 UTC
This package depends on >=net-libs/libproxy-0.3.1[python], but net-libs/libproxy currently doesn't support installation for multiple Python ABIs.
Comment 9 Pacho Ramos gentoo-dev 2011-02-07 19:26:19 UTC
(In reply to comment #7)
> You still need to update dependencies and restrict 3.* Python ABIs.

Then, looks like package passes configure and compiles with python3 but later python_optimize fails :-S

> Calling python_mod_optimize() allows to detect syntax errors.
> 

Isn't there any way for checking python stuff is not being "optimized"?