Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315307 - net-irc/irssi-otr: Verify and potentially improve Python-related code
Summary: net-irc/irssi-otr: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: kenobi
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-14 20:59 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2013-07-25 23:34 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (irssi-otr.patch,2.00 KB, patch)
2011-11-12 14:19 UTC, Ian Delaney (RETIRED)
Details | Diff
revised patch (irssi-otr.patch,1.93 KB, patch)
2011-11-14 09:18 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (irssi-otr.patch,1.84 KB, patch)
2011-11-15 07:28 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-14 20:59:21 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Raúl Porcel (RETIRED) gentoo-dev 2010-12-05 16:58:34 UTC
Patches are welcome
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2011-11-12 14:19:15 UTC
Created attachment 292283 [details, diff]
ebuild patch

Python 2.5 doesn't work.
Tested all others, all AOK.  Usual bump to EAPI 3
Comment 3 Arfrever Frehtes Taifersar Arahesis 2011-11-13 02:18:49 UTC
(In reply to comment #2)

Portage itself requires Python >=2.6 and it has no relation to Python version
required by other packages. If you install sys-apps/portage with USE="python3",
then you will be able to set active version of Python 2 to 2.4 or 2.5 and still
use Portage (Portage will use active version of Python 3 regardless of active
version of Python 2).

PYTHON_DEPEND specifies build-time and run-time dependency on Python, but this package has only build-time dependency on Python.
Such pkg_setup() is not needed.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2011-11-14 09:18:44 UTC
Created attachment 292491 [details, diff]
revised patch

done
Comment 5 Arfrever Frehtes Taifersar Arahesis 2011-11-14 19:38:34 UTC
(In reply to comment #4)

This patch contains:
-src_install() {
+rc_install() {

Maybe 'python_set_active_version 2' should be used.
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2011-11-15 07:28:59 UTC
Created attachment 292599 [details, diff]
revised ebuild patch

done
Comment 7 Arfrever Frehtes Taifersar Arahesis 2011-11-16 18:38:54 UTC
(In reply to comment #6)

PYTHON_DEPEND specifies build-time and run-time dependency on Python, but this
package has only build-time dependency on Python.
Comment 8 Sergey Popov (RETIRED) gentoo-dev 2013-07-25 23:34:37 UTC
+  25 Jul 2013; Sergey Popov <pinkbyte@gentoo.org> -irssi-otr-0.3.ebuild,
+  +irssi-otr-0.3-r1.ebuild:
+  Revision bump: EAPI 5, proper handling of python-related stuff, wrt bug
+  #315307, drop old revision