Bug 315095 – net-firewall/dshieldpy: Verify and potentially improve Python-related code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-04-13 20:50:32 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 David Abbott (RETIRED) 2010-05-02 00:42:07 UTC]

Created attachment 229959 [details]
dshieldpy-3.2-r1.ebuild

Only works with python 2

[Comment 2 Ian Delaney (RETIRED) 2011-11-23 09:22:09 UTC]

Created attachment 293491 [details, diff]
ebuild patch

works on both pyth 2 & 3 here. <=python-2.4 should cover it.
the shebang fixer is in but doesn't seem to me to really be required, same shebang with or without, so I made it commented for you to decide to include or not.

[Comment 3 Arfrever Frehtes Taifersar Arahesis 2011-11-23 20:48:03 UTC]

(In reply to comment #2)
> works on both pyth 2 & 3 here.

Obviously no:

$ /usr/bin/dshield.py --help
  File "/usr/bin/dshield.py", line 64
    exec execcode
                ^
SyntaxError: invalid syntax

[Comment 4 Ian Delaney (RETIRED) 2011-11-24 23:27:45 UTC]

Created attachment 293677 [details, diff]
revised ebuild patch

[Comment 5 Ian Delaney (RETIRED) 2011-11-25 20:47:46 UTC]

Created attachment 293759 [details, diff]
revised ebuild patch

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-25 23:42:15 UTC]

(In reply to comment #5)

This patch is for media-sound/a2jmidid.

[Comment 7 Ian Delaney (RETIRED) 2011-11-26 12:55:23 UTC]

Created attachment 293833 [details, diff]
revised ebuild patch

[Comment 8 Mike Gilbert 2011-11-26 17:11:49 UTC]

+*dshieldpy-3.2-r1 (26 Nov 2011)
+
+  26 Nov 2011; Mike Gilbert <[e-mail]> +dshieldpy-3.2-r1.ebuild:
+  Python-related improvements by Ian Delaney. Bug 315095.
+