Bug 315073 – net-analyzer/fail2ban: Verify and potentially improve Python-related code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-04-13 20:42:18 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-09 17:10:42 UTC]

*** Bug 323337 has been marked as a duplicate of this bug. ***

[Comment 2 Markos Chandras (RETIRED) 2010-11-05 15:01:35 UTC]

+*fail2ban-0.8.4-r1 (05 Nov 2010)
+
+  05 Nov 2010; Markos Chandras <[e-mail]>
+  +files/fail2ban-0.8.4-hashlib.patch, files/fail2ban-logrotate,
+  +fail2ban-0.8.4-r1.ebuild, +files/fail2ban-0.8.4-sshd-breakin.patch:
+  Bugfix revision. Fixes bug 260337,283629,301139,315073,343955. Thanks to
+  Robert Trace <[e-mail]>, Harley Peters
+  <[e-mail]> for the patches.
+

[Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-11-07 00:05:24 UTC]

The ebuild will use Python 3.* when Python 3.* is set as main active version of Python.
pkg_postinst() probably should call distutils_pkg_postinst().

[Comment 4 Markos Chandras (RETIRED) 2010-11-07 13:00:19 UTC]

Is that ok?


+pkg_setup() {
+	python_set_active_version 2
+	python_pkg_setup
+}
+
 src_prepare() {
 	epatch "${FILESDIR}"/${P}-hashlib.patch \
 		"${FILESDIR}"/${P}-sshd-breakin.patch
@@ -51,6 +56,7 @@
 }
 
 pkg_postinst() {
+	distutils_pkg_postinst
 	if [[ $previous_less_than_0_7 = 0 ]] ; then
 		elog
 		elog "Configuration files are now in /etc/fail2ban/"

[Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-11-07 14:20:17 UTC]

(In reply to comment #4)

Yes. Also please use EAPI="3". Usage of EAPI="2" with distutils.eclass in packages not supporting installation for multiple Python ABIs is deprecated.

[Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2011-03-11 20:56:48 UTC]

Fixed in net-analyzer/fail2ban-0.8.4, net-analyzer/fail2ban-0.8.4-r1 and net-analyzer/fail2ban-0.8.4-r2.