Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 315071 - net-analyzer/carl: Verify and potentially improve Python-related code
Summary: net-analyzer/carl: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Tobias Klausmann (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-13 20:41 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2010-04-19 16:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-13 20:41:46 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Tobias Klausmann (RETIRED) gentoo-dev 2010-04-14 09:32:25 UTC
I've fixed a few minor things and the soon-to-be-released 0.9 of Carl works with both Python 2.6+ and 3.1.

As for the files installed, with 3.x as the main Python installation, this is what's in image/ after ebuild carl-0.9.ebuild install:

.
`-- usr
    |-- bin
    |   `-- Carl.py
    |-- lib64
    |   `-- python3.1
    |       `-- site-packages
    |           |-- Accounts.py
    |           |-- carl-0.9-py3.1.egg-info
    |           `-- Sessions.py
    `-- share
        `-- doc
            `-- carl-0.9
                |-- COPYING
                |-- PKG-INFO.bz2
                `-- README.bz2

For 2.6 it looks the same but with a different site-dir (/usr/lib/python2.6/...). I don't see a reason why installing Carl's libs in both dirs (or a version agnostic dir) should break stuff. The script itself simply uses /usr/bin/python, so it will always use the default at the time of installation.

Is anything else (besides the release of 0.9) needed?
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-14 20:07:44 UTC
- It should be easy to support installation of Python modules for multiple Python
  versions.
- distutils.eclass adds dependency on Python, so you don't need virtual/python
  in DEPEND.
- You should set PYTHON_MODNAME="Accounts.py Sessions.py" (e.g. after DOCS).
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-19 16:19:20 UTC
Fixed in net-analyzer/carl-0.9.