Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 313987 - media-video/coherence: Verify and potentially improve Python-related code
Summary: media-video/coherence: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Jeremy Olexa (darkside) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257 349476
  Show dependency tree
 
Reported: 2010-04-08 20:02 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2011-01-11 20:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-08 20:02:00 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Michael Weber (RETIRED) gentoo-dev 2011-01-09 00:24:15 UTC
Hi,

can I please commit these changes to the ebuild?

It supports python multi abi install,
python 2.4 ha no sqlite use flag, so excluded
python 3.1 does not like the syntax, excluded
droped a ${PN} from the DESCRIPTION.

Michael

michael@io coherence % cvs diff coherence-0.6.6.1.ebuild 
Index: coherence-0.6.6.1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/media-video/coherence/coherence-0.6.6.1.ebuild,v
retrieving revision 1.5
diff -u -B -r1.5 coherence-0.6.6.1.ebuild
--- coherence-0.6.6.1.ebuild    7 Jan 2011 09:37:06 -0000       1.5
+++ coherence-0.6.6.1.ebuild    9 Jan 2011 00:21:39 -0000
@@ -3,11 +3,16 @@
 # $Header: /var/cvsroot/gentoo-x86/media-video/coherence/coherence-0.6.6.1.ebuild,v 1.5 2011/01/07 09:37:06 xmw Exp $
 
 EAPI=2
-inherit distutils
+PYTHON_DEPEND="2:2.5"
+PYTHON_USE_WITH="sqlite"
+SUPPORT_PYTHON_ABIS="1"
+RESTRICT_PYTHON_ABIS="2.4 3.*"
+
+inherit distutils python
 
 MY_P="Coherence-${PV}"
 
-DESCRIPTION="Coherence is a framework written in Python for DLNA/UPnP components"
+DESCRIPTION="A framework written in Python for DLNA/UPnP components"
 HOMEPAGE="https://coherence.beebits.net/"
 SRC_URI="http://coherence.beebits.net/download/${MY_P}.tar.gz"
 
@@ -27,7 +32,6 @@
        dev-python/axiom
        dev-python/gdata
        dev-python/feedparser
-       dev-lang/python[sqlite]
        dev-python/tagpy"
 
 S="${WORKDIR}/${MY_P}"
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-01-09 15:02:10 UTC
This package depends on some packages, which don't support Jython, so please use:
RESTRICT_PYTHON_ABIS="2.4 3.* *-jython"
Comment 3 Michael Weber (RETIRED) gentoo-dev 2011-01-11 20:23:15 UTC
+*coherence-0.6.6.2 (11 Jan 2011)
+
+  11 Jan 2011; Michael Weber <xmw@gentoo.org> coherence-0.6.6.1.ebuild,
+  +coherence-0.6.6.2.ebuild:
+  Fix python issues (bug 313987) and version bump (bug 349476).
+