Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 313937 - media-sound/christine: Verify and potentially improve Python-related code
Summary: media-sound/christine: Verify and potentially improve Python-related code
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Sound Team
: 403475 (view as bug list)
Depends on:
Blocks: 308257
  Show dependency tree
Reported: 2010-04-08 19:40 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2012-02-15 00:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

ebuild patch (christine.patch,1.46 KB, patch)
2011-11-17 20:52 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (christine.patch,1.42 KB, patch)
2011-11-21 08:47 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-08 19:40:55 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-17 20:52:47 UTC
Created attachment 292945 [details, diff]
ebuild patch
Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-20 02:21:41 UTC
(In reply to comment #1)

PYTHON_DEPEND="2:2.6" (due to dev-python/pygtk)
Use 'emake DESTDIR="${D}" install' instead of 'emake DESTDIR="${ED}" install'.
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2011-11-21 08:47:28 UTC
Created attachment 293277 [details, diff]
revised ebuild patch
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-02-15 00:06:39 UTC
*** Bug 403475 has been marked as a duplicate of this bug. ***
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2012-02-15 00:09:52 UTC
Fixed by 0.7.0 in Portage now. Thanks guys.