Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 313931 - media-sound/a2jmidid: Verify and potentially improve Python-related code
Summary: media-sound/a2jmidid: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Alexis Ballier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-04-08 19:39 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2013-05-20 16:17 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (a2jmidid.patch,3.50 KB, text/plain)
2011-11-12 15:11 UTC, Ian Delaney (RETIRED)
Details
ebuild patch revised (a2jmidid.patch,3.47 KB, patch)
2011-11-14 09:23 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (a2jmidid.patch,3.45 KB, patch)
2011-11-15 08:41 UTC, Ian Delaney (RETIRED)
Details | Diff
r (a2jmidid.patch,3.12 KB, patch)
2011-11-19 12:04 UTC, Ian Delaney (RETIRED)
Details | Diff
a2jmidid.patch (a2jmidid.patch,1.21 KB, patch)
2012-07-30 12:54 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-08 19:39:31 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-12 15:11:43 UTC
Created attachment 292289 [details]
ebuild patch

Needs ABI 2.6 2.7.
Tested, all AOK.  Usual bump EAPI to 3
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2011-11-12 15:22:23 UTC
also

* QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/j2amidi_bridge
 * /usr/bin/a2jmidi_bridge
 * /usr/bin/a2jmidid
Comment 3 Arfrever Frehtes Taifersar Arahesis 2011-11-13 02:23:38 UTC
(In reply to comment #1)

Portage itself requires Python >=2.6 and it has no relation to Python version
required by other packages. If you install sys-apps/portage with USE="python3",
then you will be able to set active version of Python 2 to 2.4 or 2.5 and still
use Portage (Portage will use active version of Python 3 regardless of active
version of Python 2).

PYTHON_DEPEND specifies build-time and run-time dependency on Python, but this package has only build-time dependency on Python.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2011-11-14 09:23:05 UTC
Created attachment 292493 [details, diff]
ebuild patch revised

done
Comment 5 Arfrever Frehtes Taifersar Arahesis 2011-11-14 19:41:52 UTC
(In reply to comment #4)

Please re-read comment #3.
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2011-11-15 08:41:26 UTC
Created attachment 292605 [details, diff]
revised ebuild patch

this, I suspect
Comment 7 Arfrever Frehtes Taifersar Arahesis 2011-11-16 18:42:46 UTC
(In reply to comment #6)

PYTHON_DEPEND specifies build-time and run-time dependency on Python, but this
package has only build-time dependency on Python.
Comment 8 Ian Delaney (RETIRED) gentoo-dev 2011-11-19 12:04:40 UTC
Created attachment 293085 [details, diff]
r
Comment 9 Arfrever Frehtes Taifersar Arahesis 2011-11-20 06:44:11 UTC
(In reply to comment #8)

This patch doesn't fix problem mentioned in comment #7 and additionally contains a regression (lack of 'python_set_active_version 2').

python_convert_shebangs() is probably not needed. If any Python scripts were installed, then there should be run-time dependency on Python.
Comment 10 Arfrever Frehtes Taifersar Arahesis 2012-07-30 12:54:49 UTC
Created attachment 319718 [details, diff]
a2jmidid.patch
Comment 11 jannis 2012-12-18 11:46:51 UTC
See also #417701
Comment 12 Alexis Ballier gentoo-dev 2013-05-20 16:17:14 UTC
(In reply to comment #10)
> Created attachment 319718 [details, diff] [details, diff]
> a2jmidid.patch

simplified and applied, thanks