if foo == None gets replaced with if foo is not None: which does just the oposite Reproducible: Always diff --git a/DEVELOPING b/DEVELOPING index 8286a8b..fc386bc 100644 --- a/DEVELOPING +++ b/DEVELOPING @@ -57,7 +57,7 @@ conventions. Comparisons ----------- -if foo == None +if foo != None should be replaced with: lines 1-13/13 (END)
Also ending is somehow unclear.
Created attachment 226737 [details, diff] Chnage == to != where suggested, remove unclear part of ending.
Thanks, your patch is in git now: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=2404704fee165a684e0d730ee3787a512fd71b60