Pretty simple (I hope). Just a version bump to 0.20.0 would be nice. Reproducible: Always Steps to Reproduce: 1. emerge -v gmpc
Just a rename of the ebuild worked for me, so this should be easy to implement.
Created attachment 227157 [details, diff] Ebuild updates for gmpc-0.20.0 In fact, it is not quite easy. A simple rename of the previous ebuild fails on my system because no Vala compiler is installed. Here is an ebuild update for gmpc-0.20.0 that works without Vala compiler: * Apply a patch to remove the check on the Vala compiler in the configure script. This is OK because Vala is only used during the build to generate several C files that are already provided in the source tarball. This avoids adding a build dependency on package dev-lang/vala. * Use eutils and autotools eclasses for epatch and eautoreconf calls. * Apply a patch on Makefile.am files to remove unused targets. This is required for eautoreconf to work. * Apply a patch on Makefile.am files to remove trailing-whitespace. This is required for eautoreconf to work. * Add dependency on >=media-libs/libmpd-0.19.2 as required by upstream. I'm going to attach the 3 patches to the bug.
Created attachment 227159 [details, diff] Ebuild updates for gmpc-0.20.0
Created attachment 227161 [details, diff] Patch to avoid the requirement for a vala compiler
Created attachment 227163 [details, diff] Patch to remove unused targets in Makefile.am files
Created attachment 227165 [details, diff] Patch to remove trailing-whitespace in Makefile.am files
The patch for the ebuild and the patches work for me on amd64 (although I had to create an ebuild for libmpd-0.20.0)
Please contact upstream for your source patches, those are not needed, so they won't be included here. To that vala patch, it seems like the current git version already removes the generated C source, so vala will be needed sooner or later. I've asked upstream about the situation, but it looks like we will need the dependency.
(In reply to comment #8) > Please contact upstream for your source patches, those are not needed, so they > won't be included here. > To that vala patch, it seems like the current git version already removes the > generated C source, so vala will be needed sooner or later. I've asked upstream > about the situation, but it looks like we will need the dependency. Where did you asked upstream about the situation? I could not find anything on the mailing list or forums. Anyway, if upstream decides not to include generated C files in release tarballs anymore, my patches are indeed useless.
on IRC: 18/195645 < angelos> DaveDavenport: is there any reason you want to remove the vala generated C source from gmpc? 18/195654 < angelos> shipping it would save a dependency on vala for source distros 19/005555 <@DaveDavenport> angelos: less crap to ship, less makefile voodoo so I'm gonna bump it this afternoon with the vala dep. Please take the other patches upstream anyway.
it would also be great to install (with use flag maybe) vapi files into vala's vapi directory (for plugin development) ( /usr/share/vala/vapi/ )
> so I'm gonna bump it this afternoon with the vala dep. > Please take the other patches upstream anyway. Done here: http://musicpd.org/mantis/view.php?id=3160
