Please see attached patch.
Created attachment 226049 [details, diff] patch for gnome2.eclass
seems like there is a couple of -> substitions, is there any reason for this ? Also, I'd prefer a real if/fi for the first line of gnome2_src_install but that's cosmetic.
meant ${D} ${ED}
${D} -> ${ED}: s/EAPI-3/Prefix/ The first line of gnome2_src_install is just in line with all other eclasses, but you can expand it if you like.
(In reply to comment #4) > ${D} -> ${ED}: s/EAPI-3/Prefix/ > I missed the "missing" word. Let me rewrite it for better comprehension: "seems like there is a couple of ${D} -> ${ED} substitions missing, is there any reason for this ?" Also could you explain what we should change to make EAPI-3/Prefix support real, EAPI cheat sheet doesn't give a clue and it seems I skipped all the EAPI 3 being move to EAPI 4 and EAPI 3 being xz+prefix support discussion on dev ml.
The only ${D} entries left in the ebuild are as follows: emake DESTDIR="${D}" ... install As econf passes --prefix="${EPREFIX}/usr", using ED here would cause a "double prefix" error (installing to $D/$EPREFIX/$EPREFIX/usr) find "${D}" -name '*.omf' This can be changed if you want - there should be absolutely no difference between $D and $ED here, as all the files are in $ED, which is a subdir of $D
Alright, feel free to commit.
In tree
