Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 312187 - dev-libs/libgamin: Verify and potentially improve Python-related code
Summary: dev-libs/libgamin: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
: 310485 323527 (view as bug list)
Depends on:
Blocks: 308257 313471
  Show dependency tree
 
Reported: 2010-03-30 19:39 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2010-06-16 18:44 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libgamin-0.1.10-disable_python_static_library.patch (libgamin-0.1.10-disable_python_static_library.patch,340 bytes, patch)
2010-06-16 18:13 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details | Diff
libgamin-0.1.10-r2.ebuild.patch (libgamin-0.1.10-r2.ebuild.patch,2.60 KB, patch)
2010-06-16 18:16 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-30 19:39:02 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-11 14:45:07 UTC
*** Bug 323527 has been marked as a duplicate of this bug. ***
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-16 18:13:24 UTC
Created attachment 235623 [details, diff]
libgamin-0.1.10-disable_python_static_library.patch

This patch disables building of static version of Python module.
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-16 18:16:47 UTC
Created attachment 235627 [details, diff]
libgamin-0.1.10-r2.ebuild.patch

This patch adds support for installation for multiple Python ABIs and fixes other problems.

I will commit this patch, if you don't object in 1 week.
Comment 4 Dror Levin (RETIRED) gentoo-dev 2010-06-16 18:32:51 UTC
Seems OK to me, feel free to commit :)
Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-16 18:44:17 UTC
Fixed.
Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-06-16 18:44:53 UTC
*** Bug 310485 has been marked as a duplicate of this bug. ***