Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 311781 - app-portage/kportagetray: Verify and potentially improve Python-related code
Summary: app-portage/kportagetray: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal
Assignee: Ronan Arraes Jardim Chagas
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-03-28 16:09 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2010-03-31 22:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff between current and new ebuild w/verbump (kportagetray-0.2.2-to-0.2.3.ebuild.patch,469 bytes, patch)
2010-03-31 21:17 UTC, Ai Locke Shinseiko (Wizzleby)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-28 16:09:12 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ai Locke Shinseiko (Wizzleby) 2010-03-29 19:02:43 UTC
(In reply to comment #0)
Thank you for your attention to kportagetray and for the helpful documents as
well. 

Since Ronan is busy with school currently, I have volunteered to handle both code cleanup and porting for py3k compatibility.

kportagetray is currently simply incompatibly with Python3, but I do hope to rectify that before much longer.

I can update the ebuilds as per suggestions here, but I have not commit access to g-x86 nor kde overlay, so someone else will need to push the changes which I will attach to this bug.
Comment 2 Ai Locke Shinseiko (Wizzleby) 2010-03-31 21:17:37 UTC
Created attachment 226019 [details, diff]
diff between current and new ebuild w/verbump
Comment 3 Ai Locke Shinseiko (Wizzleby) 2010-03-31 22:18:35 UTC
fixed ebuild is now in gentoo-x86, -9999 version fixed in kde overlay. Old versions are removed. This bug can be closed.
Comment 4 Ai Locke Shinseiko (Wizzleby) 2010-03-31 22:43:24 UTC
Note: kportagetray itself appears python3 ready however we depend on dbus-python, which does not support python3
Comment 5 Ronan Arraes Jardim Chagas 2010-03-31 22:59:59 UTC
So, since Wizzleby solved all issues, I'm closing the bug.