Bug 311665 – app-mobilephone/obexftp: Verify and potentially improve Python-related code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-27 22:19:30 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Sebastian Luther (few) 2010-05-18 08:21:45 UTC]

*** Bug 319975 has been marked as a duplicate of this bug. ***

[Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-05-31 18:14:41 UTC]

Created attachment 233705 [details, diff]
obexftp.patch

This patch only removes deprecation warnings and adds calls to python_mod_cleanup() in pkg_postrm().

I will commit this patch, if you don't object in 1 week.

[Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-08 16:26:36 UTC]

(I accidentally reassigned this bug when attaching patch.)

[Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-08 16:29:39 UTC]

Comment on attachment 233705 [details, diff]
obexftp.patch

Committed.

[Comment 5 Chris Mayo 2011-02-26 15:59:50 UTC]

obexftp-0.23-r1 emerge fails if Python3 is default:

make[3]: Entering directory `/var/tmp/portage/app-mobilephone/obexftp-0.23-r1/work/obexftp-0.23/swig/python'
if test ! -f python_wrap.c; then cp ./python_wrap.c . ; fi
/usr/bin/python setup.py build
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    extra_link_args = string.split('-L../../obexftp/.libs -lobexftp -L../../multicobex/.libs -lmulticobex -L../../bfb/.libs -lbfb -lopenobex  '),
AttributeError: 'module' object has no attribute 'split'
make[3]: *** [all-local] Error 1

Adding:
PYTHON_DEPEND="python? 2"

and:

pkg_setup() {
	if use python; then
		python_set_active_version 2
	fi
}

fixes it for me.

[Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2011-04-25 18:29:51 UTC]

Fixed in app-mobilephone/obexftp-0.23-r1.