Bug 311537 – app-misc/webcomics-collector: Verify and potentially improve Python-related code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-26 21:35:10 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into directories specific to given versions of Python,
  then consider supporting installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1].

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 David Abbott (RETIRED) 2010-05-01 23:43:02 UTC]

Looks like it will not work with python 3, it does install with 2, or 3.

python /usr/lib64/python3.1/site-packages/Collector.py
  File "/usr/lib64/python3.1/site-packages/Collector.py", line 211
    except ConfigParser.NoSectionError, error:
                                      ^
SyntaxError: invalid syntax

[Comment 2 David Abbott (RETIRED) 2010-05-01 23:49:59 UTC]

Created attachment 229957 [details]
webcomics-collector-0.7.3-r1.ebuild

[Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-05-03 16:20:54 UTC]

Please use PYTHON_USE_WITH="gdbm" (set before call to inherit()) and empty DEPEND/RDEPEND. Please set PYTHON_MODNAME variable.

[Comment 4 David Abbott (RETIRED) 2010-05-03 20:25:37 UTC]

Created attachment 230199 [details]
webcomics-collector-0.7.3-r1.ebuild

updated per Arfrever, thanks

[Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-05-03 20:36:07 UTC]

There should be: PYTHON_MODNAME="Collector.py"

Also call distutils_pkg_postinst() in pkg_postinst().

[Comment 6 David Abbott (RETIRED) 2010-05-03 20:56:11 UTC]

Created attachment 230203 [details]
webcomics-collector-0.7.3-r1.ebuild

Ok I see why it needs the .py there is no Collector directory with this.

[Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2011-01-12 14:36:25 UTC]

Fixed in app-misc/webcomics-collector-0.7.3.