Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 311529 - app-misc/lcd4linux: Verify and potentially improve Python-related code
Summary: app-misc/lcd4linux: Verify and potentially improve Python-related code
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: No maintainer - Look at if you want to take care of it
Depends on:
Blocks: 308257
  Show dependency tree
Reported: 2010-03-26 21:32 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2012-05-06 16:25 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

ebuild patch (lcd4linux.patch,2.27 KB, patch)
2011-11-23 04:41 UTC, Ian Delaney (RETIRED)
Details | Diff
ebuild patch (lcd4linux.patch,2.04 KB, patch)
2011-11-24 23:39 UTC, Ian Delaney (RETIRED)
Details | Diff
the added lcd4linux-header.patch (lcd4linux-header.patch,337 bytes, patch)
2011-11-26 10:30 UTC, Ian Delaney (RETIRED)
Details | Diff
revised ebuild patch (lcd4linux.patch,1.57 KB, patch)
2011-11-26 10:35 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-26 21:32:37 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into directories specific to given versions of Python,
  then consider supporting installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1].

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-23 04:41:31 UTC
Created attachment 293469 [details, diff]
ebuild patch

This comes with an extra.  The build produces a QA issue, clearly missing a header file, which is sys/stat.h.  I called it ${PN}"-header.patch and is appended in the ebuild patch.  Probably too old to bother sending upstream, but it works
Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-23 20:36:34 UTC
(In reply to comment #1)

Use PYTHON_DEPEND="python? 2"
Delete 'python? ( dev-lang/python )' from DEPEND/RDEPEND.
Don't add 'python? ( =dev-lang/python-2* )' to DEPEND/RDEPEND.

python_set_active_version() should be called only with USE="python".
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2011-11-24 23:39:38 UTC
Created attachment 293679 [details, diff]
ebuild patch
Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-25 21:17:36 UTC
(In reply to comment #3)

This patch doesn't apply cleanly.
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2011-11-26 10:30:18 UTC
Created attachment 293801 [details, diff]
the added lcd4linux-header.patch
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2011-11-26 10:35:33 UTC
Created attachment 293805 [details, diff]
revised ebuild patch

remade it, first ofcourse add to files the previous lcd4linux-header.patch.
Double checked this patch and it takes.
Comment 7 Pacho Ramos gentoo-dev 2012-05-06 16:25:05 UTC
+  06 May 2012; Pacho Ramos <>
+  +files/lcd4linux-0.10.1_rc2-missing-header.patch,
+  lcd4linux-0.10.1_rc2-r2.ebuild:
+  Let it work with python3 as main interpreter and include missing header
+  (#311529 by Ian Delaney).