Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 311441 - app-shells/gentoo-bashcomp-20091225: revdep-rebuild completion broken
Summary: app-shells/gentoo-bashcomp-20091225: revdep-rebuild completion broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2010-03-26 13:36 UTC by Martin von Gagern
Modified: 2010-12-17 04:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
cleanup _revdep_rebuild (gentoo311441a.patch,3.39 KB, patch)
2010-07-12 16:55 UTC, Martin von Gagern
Details | Diff
Rebased patch (gentoo311441b.patch,3.49 KB, patch)
2010-12-13 07:42 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2010-03-26 13:36:35 UTC
Type "revdep-rebuild -i -L /lib/libz" and try to complete that.
Expected: libz.so and its versioned derivatives listed as completions.
Actual result: Nothing listed at all.
Reason: the "-i" is considered to be the action here, not the "-L".
Comment 1 Martin von Gagern 2010-07-12 16:55:56 UTC
Created attachment 238467 [details, diff]
cleanup _revdep_rebuild

Cleaned up a lot of unused code in that function. Things seem to work better now. If there are remaining issues, you might consider calling _filedir from the .pre collection of completion helper functions.
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-12-12 03:31:46 UTC
Could you clean up the patch so it is easier to apply? It needs to be rebased to http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-bashcomp/
Comment 3 Martin von Gagern 2010-12-13 07:42:17 UTC
Created attachment 257005 [details, diff]
Rebased patch

(In reply to comment #2)
> Could you clean up the patch so it is easier to apply? It needs to be rebased
> to http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-bashcomp/

Rebased to take @GENTOO_PORTAGE_EPREFIX@ into account.

It would be nice if there were a path of no more than three easy to find clicks from the package homepage, as eix prints it, to the source repository against which you want contributed patches. All I had to go by for my original patch was the tarball.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-12-17 03:43:03 UTC
thx
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-12-17 04:18:29 UTC
+*gentoo-bashcomp-20101217 (17 Dec 2010)
+
+  17 Dec 2010; Jeremy Olexa <darkside@gentoo.org>
+  +gentoo-bashcomp-20101217.ebuild:
+  Version bump to fix bugs 311441, 327953