Bug 311373 – sys-apps/smartmontools doesn't expect GNU make on FreeBSD

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Johan Hattne 2010-03-26 01:59:17 UTC]

sys-apps/smartmontools-5.39.1 build system uses BSD make syntax when building on FreeBSD.  One can either build with FreeBSD /usr/bin/make or remove special BSD syntax from Makefile.

Reproducible: Always

Steps to Reproduce:
emerge smartmontools
Actual Results:  
sys-apps/smartmontools fails compile.

Expected Results:  
sys-apps/smartmontools merges.

In sys-apps/smartmontools-5.39.1 on can add something like this to the ebuild in order to use BSD make

src_compile() {
       /usr/bin/make || die
}

[Comment 1 Johan Hattne 2010-03-26 02:02:51 UTC]

Created attachment 225277 [details, diff]
Patch to remove BSD make stuff that offends GNU make

I just now realise that the proper fix is probably to decide on which syntax to use depending on the flavour of make, not the flavour of the operating system.

[Comment 2 Alexis Ballier 2010-04-25 19:25:38 UTC]

can you try 'MAKE=make emake ...' instead?

[Comment 3 Johan Hattne 2010-04-27 02:21:26 UTC]

(In reply to comment #2)
> can you try 'MAKE=make emake ...' instead?

I hadn't thought of that, but it does work!

Could MAKE="make" be set at the top of the ebuild in order to avoid adding the trivial implementation of the src_compile() function (it'd only contain MAKE="make" emake ...)?

[Comment 4 Dmitri Bogomolov 2011-02-08 22:31:01 UTC]

What you think about dependency on virtual/mailx?

[Comment 5 Johan Hattne 2011-02-09 19:31:02 UTC]

This is fixed by upstream in smartmontools-5.40.  The virtual/mailx issue is mentioned in #306321, although I really think that it is a problem with sys-freebsd/freebsd-ubin.  Thanks!