Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 311183 - app-emulation/ganeti: Verify and potentially improve Python-related code
Summary: app-emulation/ganeti: Verify and potentially improve Python-related code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Lance Albertson (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 308257
  Show dependency tree
 
Reported: 2010-03-24 19:33 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2012-12-24 17:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (ganeti.patch,506 bytes, patch)
2011-11-29 10:30 UTC, Ian Delaney (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-24 19:33:06 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into directories specific to given versions of Python,
  then consider supporting installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1].

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-11-29 10:30:53 UTC
Created attachment 294159 [details, diff]
ebuild patch

Almost missed the ecripts in /usr//sbin.  
Does it not warrant RESTRICT_PYTHON_ABIS="2.[45]"?
Comment 2 Adam Tygart 2012-12-14 04:22:05 UTC
Not sure if this is the right bug report to handle this, but because simplejson (a required dependency of Ganeti) doesn't currently support python 3, Gentoo should force python2 for the configure/compile of Ganeti so that it properly finds its dependencies.
Comment 3 Lance Albertson (RETIRED) gentoo-dev 2012-12-24 07:37:17 UTC
Fixed in 2.5.2-r2 and 2.6.2.
Comment 4 Arfrever Frehtes Taifersar Arahesis 2012-12-24 16:23:30 UTC
Code in app-emulation/ganeti-2.6.2 violates metadata invariance.
Comment 5 Lance Albertson (RETIRED) gentoo-dev 2012-12-24 17:43:41 UTC
(In reply to comment #4)
> Code in app-emulation/ganeti-2.6.2 violates metadata invariance.

I think I know what you're referring to but can you please clarify where it violates it?
Comment 6 Lance Albertson (RETIRED) gentoo-dev 2012-12-24 17:46:07 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Code in app-emulation/ganeti-2.6.2 violates metadata invariance.
> 
> I think I know what you're referring to but can you please clarify where it
> violates it?

Never mind, I just noticed the new bug you created for this in #448432.