Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 311133 - app-text/xournal-0.4.5-r1 should not depend on gnome-base/libgnomeprint anymore
Summary: app-text/xournal-0.4.5-r1 should not depend on gnome-base/libgnomeprint anymore
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Andreas K. Hüttel
URL:
Whiteboard:
Keywords:
: 350298 (view as bug list)
Depends on:
Blocks: 352952
  Show dependency tree
 
Reported: 2010-03-24 15:18 UTC by Sebastian Dörner
Modified: 2011-09-17 11:34 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild, includes patch for `implicit declarations` (xournal-0.4.5-r2.ebuild,1.11 KB, text/plain)
2010-10-07 22:30 UTC, Michael Weber (RETIRED)
Details
patch for read/write from unistd.h and intra-package headers (xournal-0.4.5-includes.patch,1.15 KB, patch)
2010-10-07 22:31 UTC, Michael Weber (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Dörner 2010-03-24 15:18:45 UTC
From version 0.4.5 on, xournal uses gtk-print instead of libgnomeprint as can be seen on http://xournal.sourceforge.net/manual.html#changelog . Note that it is not explicitly mentioned under "UPDATED DEPENDENCIES", but still the formerly included library is not used anymore.

Reproducible: Always

Steps to Reproduce:

Actual Results:  
libgnomeprint and libgnomeprintui are dependencies of xournal-0.4.5-r1

Expected Results:  
libgnomeprint and libgnomeprintui are NOT dependencies of xournal-0.4.5-r1
Comment 1 Mart Raudsepp gentoo-dev 2010-03-24 16:09:54 UTC
IT's mentioned in ChangeLog shipped with the package too, and probably could be seen from simply diffing configure.in between older and newer xournal as well (a common practice to confirm if deps changed or not with a newer version).

Assigning to maintainer
Comment 2 Michael Weber (RETIRED) gentoo-dev 2010-10-07 21:26:40 UTC
Any progress on that?

io xournal # diff -ru /var/tmp/portage/app-text/xournal-0.4.2.1-r1/work/xournal-0.4.2.1/configure.in /var/tmp/portage/app-text/xournal-0.4.5-r1/work/xournal-0.4.5/configure.in 
--- /var/tmp/portage/app-text/xournal-0.4.2.1-r1/work/xournal-0.4.2.1/configure.in      2008-03-27 22:23:37.000000000 +0100
+++ /var/tmp/portage/app-text/xournal-0.4.5-r1/work/xournal-0.4.5/configure.in  2009-10-02 08:42:02.000000000 +0200
@@ -1,22 +1,33 @@
 dnl Process this file with autoconf to produce a configure script.
 
 AC_INIT(configure.in)
-AM_INIT_AUTOMAKE(xournal, 0.4.2.1)
+AM_INIT_AUTOMAKE(xournal, 0.4.5)
 AM_CONFIG_HEADER(config.h)
 AM_MAINTAINER_MODE
 
 AC_ISC_POSIX
 AC_PROG_CC
 AM_PROG_CC_STDC
+AC_PROG_RANLIB
 AC_HEADER_STDC
 
-pkg_modules="gtk+-2.0 >= 2.4.0 libgnomecanvas-2.0 >= 2.4.0 libgnomeprintui-2.2 >= 2.0.0"
+pkg_modules="gtk+-2.0 >= 2.10.0 libgnomecanvas-2.0 >= 2.4.0 poppler-glib >= 0.5.4"
 PKG_CHECK_MODULES(PACKAGE, [$pkg_modules])
 AC_SUBST(PACKAGE_CFLAGS)
 AC_SUBST(PACKAGE_LIBS)
 
+GETTEXT_PACKAGE=xournal
+AC_SUBST(GETTEXT_PACKAGE)
+AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GETTEXT_PACKAGE", [Gettext package.])
+
+dnl Add the languages which your application supports here.
+ALL_LINGUAS="`grep -v '^#' "$srcdir/po/LINGUAS" | tr '\n' ' '`"
+AM_GLIB_GNU_GETTEXT
+
 AC_OUTPUT([
 Makefile
 src/Makefile
+src/ttsubset/Makefile
+po/Makefile.in
 ])
Comment 3 Michael Weber (RETIRED) gentoo-dev 2010-10-07 22:30:15 UTC
Created attachment 249895 [details]
updated ebuild, includes patch for `implicit declarations`
Comment 4 Michael Weber (RETIRED) gentoo-dev 2010-10-07 22:31:03 UTC
Created attachment 249897 [details, diff]
patch for read/write from unistd.h and intra-package headers
Comment 5 Rafał Mużyło 2011-01-01 18:43:26 UTC
*** Bug 350298 has been marked as a duplicate of this bug. ***
Comment 6 Pacho Ramos gentoo-dev 2011-06-09 10:00:14 UTC
Any news on this?
Comment 7 Pacho Ramos gentoo-dev 2011-09-10 16:32:46 UTC
(In reply to comment #3)
> Created attachment 249895 [details]
> updated ebuild, includes patch for `implicit declarations`

(In reply to comment #4)
> Created attachment 249897 [details, diff]
> patch for read/write from unistd.h and intra-package headers

These are different problems that should be reported on a different bug report.

About wrong dependency, I will fix it myself if nobody disagrees in a week
Comment 8 Andreas K. Hüttel archtester gentoo-dev 2011-09-17 11:34:30 UTC
Fixed in 0.4.5-r2