Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 310605 - dev-libs/libre2: new ebuild
Summary: dev-libs/libre2: new ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Default Assignee for New Packages
URL: https://code.google.com/p/re2/
Whiteboard: [sunrise-overlay]
Keywords: EBUILD, InOverlay
Depends on:
Blocks: 357443 357441
  Show dependency tree
 
Reported: 2010-03-21 20:43 UTC by Alex Efros
Modified: 2012-12-12 17:29 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-libs/libre2-100319 ebuild (libre2-100319.ebuild,615 bytes, text/plain)
2010-03-21 20:45 UTC, Alex Efros
Details
dev-libs/re2 (re2-9999.ebuild,485 bytes, text/plain)
2010-10-08 06:35 UTC, Ishan Arora
Details
re2-9999.ebuild (install into /usr) (re2-9999.ebuild,541 bytes, text/plain)
2011-03-04 23:06 UTC, Martin Mokrejš
Details
re2-20120629.ebuild (re2-20120629.ebuild,552 bytes, text/plain)
2012-06-29 19:39 UTC, Jauhien Piatlicki (RETIRED)
Details
dev-libs/libre2-120529.ebuild (libre2-120529.ebuild,871 bytes, text/plain)
2012-06-30 05:37 UTC, Alex Efros
Details
re2-0_pre20120629.ebuild (re2-0_pre20120629.ebuild,580 bytes, text/plain)
2012-07-05 19:17 UTC, Jauhien Piatlicki (RETIRED)
Details
re2-0_pre20120629-makefile.patch (re2-0_pre20120629-makefile.patch,474 bytes, patch)
2012-07-05 19:18 UTC, Jauhien Piatlicki (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Efros 2010-03-21 20:43:47 UTC
Ebuild for new re2 library: https://code.google.com/p/re2/

Reproducible: Always

Steps to Reproduce:
Comment 1 Alex Efros 2010-03-21 20:45:27 UTC
Created attachment 224579 [details]
dev-libs/libre2-100319 ebuild
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2010-03-23 19:51:27 UTC
Hello, The Gentoo Team would like to firstly thank you for your ebuild 
submission. We also apologize for not being able to accommodate you in a timely
manner. There are simply too many new packages.

Allow me to use this opportunity to introduce you to Gentoo Sunrise. The 
sunrise overlay[1] is a overlay for Gentoo which we allow trusted users to 
commit to and all users can have ebuilds reviewed by Gentoo devs for entry 
into the overlay. So, the sunrise team is suggesting that you look into this 
and submit your ebuild to the overlay where even *you* can commit to. =)

Thanks,
On behalf of the Gentoo Sunrise Team,
Justin.

[1]: http://www.gentoo.org/proj/en/sunrise/
[2]: http://overlays.gentoo.org/proj/sunrise/wiki/SunriseFaq

Comment 3 Ishan Arora 2010-10-08 06:35:34 UTC
Created attachment 249910 [details]
dev-libs/re2

I am attaching a mercurial.eclass based live ebuild for re2 (the official website lists no other releases). I believe the name re2 should be prefered to libre2 as appears from the the official website.
Comment 4 Martin Mokrejš 2011-03-04 22:03:39 UTC
A nice page on regexps is at http://swtch.com/~rsc/regexp/ from RE2 author. It also allows fuzzy (approximate) matching.
Comment 5 Martin Mokrejš 2011-03-04 22:27:07 UTC
I installed the -9999.ebuild on my ~x86 and "g++ -Wall" did not show any warning with gcc-4.5.2, wow. ;-) Could this go into the main tree instead of sunrise?
Comment 6 Martin Mokrejš 2011-03-04 23:06:00 UTC
Created attachment 264779 [details]
re2-9999.ebuild (install into /usr)

The Makefile defines
prefix=/usr/local
so we have to overwrite its value. Once upstream changes that to
PREFIX=/usr/local
we break again.

Probably force both variables from ebuild and not just 'prefix=/usr' as in this ebuild right now.
Comment 7 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-06-29 19:39:58 UTC
Created attachment 316643 [details]
re2-20120629.ebuild

New ebuild that uses snapshot. Planning add it to the sunrise.
Comment 8 Alex Efros 2012-06-30 05:37:52 UTC
Created attachment 316733 [details]
dev-libs/libre2-120529.ebuild

Ebuild with support to install 32-bit version of libre2 on amd64. It's needed by some 32-bit apps, for ex. OS Inferno.
Comment 9 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-07-05 19:17:52 UTC
Created attachment 317340 [details]
re2-0_pre20120629.ebuild

New ebuild, amd64 support added, test respects CXX now. Thanks to hasufell.
Comment 10 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-07-05 19:18:22 UTC
Created attachment 317342 [details, diff]
re2-0_pre20120629-makefile.patch
Comment 11 Jauhien Piatlicki (RETIRED) gentoo-dev 2012-07-05 19:53:59 UTC
This is now in the sunrise overlay. You can find it after review at:
http://git.overlays.gentoo.org/gitweb/?p=proj/sunrise-reviewed.git;a=tree;f=dev-libs/re2
Comment 12 Mike Gilbert gentoo-dev 2012-08-08 01:47:45 UTC
The Gentoo Chromium team might move this to the tree shortly; the latest version of Chromium uses a bundled copy of this library. I just need to see how much work it will be to unbundle it.
Comment 13 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-08-11 10:38:42 UTC
(In reply to comment #12)
> The Gentoo Chromium team might move this to the tree shortly; the latest
> version of Chromium uses a bundled copy of this library. I just need to see
> how much work it will be to unbundle it.

I think we can add it even before it gets unbundled in Chromium. However, we should use official tarballs, not some random thing from someone's github. I've asked upstream about this, see https://groups.google.com/d/topic/re2-dev/znoD8CrEV0Y/discussion
Comment 14 Mike Gilbert gentoo-dev 2012-08-11 15:44:10 UTC
Jauhien's ebuild in sunrise is pretty good.

I did some tweaking to avoid patching the Makefile and install some missing docs. Alternatively, if we can push some Makefile changes upstream, the ebuild does get a little simpler.

My work is in my overlay, and I uploaded a snapshot to my devspace.

https://bitbucket.org/floppym/floppym-overlay/src/default/dev-libs/re2

I'll wait until we hear about the tarballs before moving it to the tree.
Comment 15 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-10-23 04:14:48 UTC
(In reply to comment #14)
> Alternatively, if we can push some Makefile changes upstream, the
> ebuild does get a little simpler.

If you have some patches, I can help with the upstreaming or pinging the upstream.

> My work is in my overlay, and I uploaded a snapshot to my devspace.
> 
> https://bitbucket.org/floppym/floppym-overlay/src/default/dev-libs/re2
> 
> I'll wait until we hear about the tarballs before moving it to the tree.

Looks like we have at least one tarball on https://code.google.com/p/re2/downloads/list . I'm not yet sure how often new ones will appear.

Looks like it can be moved to main tree if you want.
Comment 16 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-10-31 03:37:11 UTC
Added. Thanks everyone!
Comment 17 Alex Efros 2012-12-12 08:58:52 UTC
(In reply to comment #16)
> Added. Thanks everyone!

Any chance to add 32-bit support to this ebuild, to let me drop it from my overlay?

32-bit version of re2 library required to build OS Inferno (which is 32-bit only) linked with re2.

Simple way is add USE flag 32bit and if it set add -m32 both to CPPFLAGS and LDFLAGS. Better way probably is install both 64- and 32-bit versions.
Comment 18 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-12-12 16:41:27 UTC
(In reply to comment #17)
> (In reply to comment #16)
> > Added. Thanks everyone!
> 
> Any chance to add 32-bit support to this ebuild, to let me drop it from my
> overlay?

You probably mean 32-bit on 64-bit system, because the ebuild does have ~x86 keyword. Note that the proper solution for your case would be multilib portage rather than ad-hoc hacks in random ebuilds.

> Simple way is add USE flag 32bit and if it set add -m32 both to CPPFLAGS and
> LDFLAGS. Better way probably is install both 64- and 32-bit versions.

Sorry, I'm not going to do that for re2. There are better technical alternatives like multilib portage.
Comment 19 Alex Efros 2012-12-12 17:04:44 UTC
(In reply to comment #18)
> You probably mean 32-bit on 64-bit system,

Yes.
 
> Sorry, I'm not going to do that for re2. There are better technical
> alternatives like multilib portage.

AFAIK I'm using multilib profile (hardened/linux/amd64) and I see multilib in my USE flags (in emerge --info output). How this can help me to build 32-bit application linked with re2 library? Or how to build 32-bit version of re2 library using current ebuild in portage on my multilib system?
Comment 20 Mike Gilbert gentoo-dev 2012-12-12 17:29:47 UTC
(In reply to comment #19)

Paweł is referring to the "multilib-portage" project, which is a fork of the official portage package manager, and an overlay with a few supporting packages.

You can find setup instructions here, and support in #gentoo-multilib-overlay.

http://git.overlays.gentoo.org/gitweb/?p=proj/multilib-portage.git;a=blob;f=doc/portage-multilib-instructions