Bug 310513 – Please update perl-module.eclass for EAPI=3

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Fabian Groffen 2010-03-21 10:48:08 UTC]

perl-module.eclass is not yet ready for EAPI=3.  The attached patch is a suggestion on what could be done to make it so.

[Comment 1 Fabian Groffen 2010-03-21 10:49:09 UTC]

Created attachment 224479 [details, diff]
perl-module EAPI=3 patch

[Comment 2 Torsten Veller (RETIRED) 2010-03-21 11:51:00 UTC]

It's already in <http://git.overlays.gentoo.org/gitweb/?p=proj/perl-overlay.git;a=tree;f=eclass;hb=HEAD>. Testing will reveal if i missed anything.

The eclass function names might change if we can come up with something better.

I'll ask for review/comments in -dev soon.

[Comment 3 Fabian Groffen 2010-03-21 11:56:46 UTC]

Ok.

Looks like your EAPI case statement in perl-module.eclass doesn't handle EAPI=3, is that correct?

[Comment 4 Torsten Veller (RETIRED) 2010-03-21 21:49:01 UTC]

(In reply to comment #3)
> Looks like your EAPI case statement in perl-module.eclass doesn't handle
> EAPI=3, is that correct?

I fixed it. Thanks

[Comment 5 Torsten Veller (RETIRED) 2010-03-30 07:44:46 UTC]

07:35 <@ABCD> the hunks where `find "${D}" -type f ...` is changed to 
              `find "${ED}" -type f ...` are not needed, as 
              they will end up finding the exact same files
07:37 <@ABCD> so the fixlocalpod() function can be left entirely alone 
              (everything in it works just fine with $D instead of $ED,
              as there are never any files in $D that are not in $ED 
              (if there are, the build will fail anyway))

Changed.

[Comment 6 Torsten Veller (RETIRED) 2010-04-17 19:59:35 UTC]

http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/perl-module.eclass?r1=1.122&r2=1.123